Commit updates of the qmk_firmware submodule #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radmen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was experimenting with new things I added to the source code and didn't want to wait for GH to finish the workflow (I figured that local compilation will be faster). However, I'm not very bright as it comes to QMK :)
I thought that the default
qmk_firmwaresubmodule will work by default, but it didn't. It took me some time to figure out that I should grab the most recent firmware version, which matches the one used by Oryx. I think it would be good to commit the updates to the main repo to avoid any future problems.This PR changes slightly the firmware checkout step. It will make a shallow copy of the submodule, switch to the
firmwareXbranch (since it's a shallow copy, this will be the latest version) and commit the changes. The changes have been tested in my forked repo.