CGMES. Import StaticVarCompensators: sVCControlMode and voltageSetPoint are deprecated and optional in CGMES 3.0 #3272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: marquesja1 <marquesja@aia.es>
Signed-off-by: marquesja1 <marquesja@aia.es>
Signed-off-by: marquesja1 <marquesja@aia.es>
zamarrenolm
changed the title
zamarrenolm
requested changes
Jan 14, 2025
...gmes-conversion/src/test/java/com/powsybl/cgmes/conversion/test/export/ExportXmlCompare.java
Show resolved
Hide resolved
...gmes-conversion/src/test/java/com/powsybl/cgmes/conversion/test/export/ExportXmlCompare.java
Show resolved
Hide resolved
...main/java/com/powsybl/cgmes/conversion/RegulatingControlMappingForStaticVarCompensators.java
Outdated
Show resolved
Hide resolved
Signed-off-by: marquesja1 <marquesja@aia.es>
zamarrenolm
approved these changes
Jan 14, 2025
rcourtier
requested changes
Jan 16, 2025
cgmes/cgmes-conversion/src/test/resources/staticVarCompensator/staticVarCompensator_EQ.xml
Outdated
Show resolved
Hide resolved
...mes-conversion/src/test/java/com/powsybl/cgmes/conversion/test/StaticVarCompensatorTest.java
Show resolved
Hide resolved
Signed-off-by: marquesja1 <marquesja@aia.es>
Signed-off-by: marquesja1 <marquesja@aia.es>
…ring_controlMode_and_voltageSetpoint_optionals
rcourtier
requested changes
Jan 17, 2025
...mes-conversion/src/test/java/com/powsybl/cgmes/conversion/test/StaticVarCompensatorTest.java
Outdated
Show resolved
Hide resolved
rcourtier
requested changes
Jan 17, 2025
...mes-conversion/src/test/java/com/powsybl/cgmes/conversion/test/StaticVarCompensatorTest.java
Outdated
Show resolved
Hide resolved
…ion/test/StaticVarCompensatorTest.java Co-authored-by: rcourtier <129156292+rcourtier@users.noreply.github.com> Signed-off-by: marqueslanauja <51124986+marqueslanauja@users.noreply.github.com>
…ion/test/StaticVarCompensatorTest.java Co-authored-by: rcourtier <129156292+rcourtier@users.noreply.github.com> Signed-off-by: marqueslanauja <51124986+marqueslanauja@users.noreply.github.com>
Signed-off-by: marquesja1 <marquesja@aia.es>
rcourtier
requested changes
Jan 17, 2025
...mes-conversion/src/test/java/com/powsybl/cgmes/conversion/test/StaticVarCompensatorTest.java
Outdated
Show resolved
Hide resolved
...mes-conversion/src/test/java/com/powsybl/cgmes/conversion/test/StaticVarCompensatorTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: marquesja1 <marquesja@aia.es>
Signed-off-by: marquesja1 <marquesja@aia.es>
|
rcourtier
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
The attributes
svcControlModeandvoltageSetpointare optional in CGMES 3.0. The current version treats these attributes as mandatory, so staticVarCompensators without them are not imported.What is the new behavior (if this is a feature change)?
Now, these attributes are treated as optional. StaticVarCompensators without them are imported.
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: