Modified exception message when initial LF fails in AC Sensi #1170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: PRABAKARAN Sylvestre <sylvestre.prabakaran@rte-france.com>
Signed-off-by: PRABAKARAN Sylvestre <sylvestre.prabakaran@rte-france.com>
Signed-off-by: PRABAKARAN Sylvestre <sylvestre.prabakaran@rte-france.com>
|
| throw new PowsyblException("Load flow ended with outer loop status " + result.getOuterLoopResult().statusText()); | ||
| } else { | ||
| throw new PowsyblException("Load flow ended with solver status " + result.getSolverStatus()); | ||
| } |
There was a problem hiding this comment.
The message can still be improved by specifying that this is the load flow of the N case
(failures for contingencies don't interrupt the analysis)
For this you can also rename the parameter from throwsExceptionIfNoConvergence to something like runBaseSituation (te clarify its meaning since now the message would depend on this param) , and make the message more precise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Misleading exception message was thrown when load flow fails in AC sensi analysis. A correction is done to this message.
What is the current behavior?
When running an AC sensitivity analysis, if the first load flow fails because of UNSTABLE outer loop status, a PowsyblException is thrown with message : "Load flow ended with status CONVERGED"
What is the new behavior (if this is a feature change)?
A correct exception message is thrown depending on Load flow result.
Does this PR introduce a breaking change or deprecate an API?
Other information: