Fix toolbox settings hiding when dragging a slider #31596
Draft
+8
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is a issue, when the slider is released, the setting doesn't hide. issue1.mp4Please don't review. I think there is a understanding issue by me |
|
So, the reason of the issue is that it's only update with OnHover and OnHoverLost, so it's not updating when releasing a slider outside the toolbox. I tried adding OnMouseUp but it didn't work, inputManager.DraggedDrawable is true in this call. If someone could suggest me an idea it would be cool, I'm learning C#. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need ppy/osu-framework#6500
Fix in the beatmap loading screen and in a replay
Before :
In replay
before.mp4
In beatmap loading
before.beatmap.mp4
After:
In replay
after.mp4
In beatmap loading
after.beatmap.mp4