Replace bashisms in the configure scripts #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the use of `+=` operator with plain assignment to fix
compatibility with shells other than bash. Without this script,
the build fails on systems where /bin/sh is not bash (and e.g. dash).
The original code leads to errors such as:
./configure: 14711: PRAGHA_CFLAGS+= ... : not found
since the assignment is wrongly taken to be a command to execute.
As a result, flags are not being appended and the build eventually
fails with e.g.:
pragha-cmdline.c:33:10: fatal error: libxfce4ui/libxfce4ui.h: No such file or directory
Original bug report: https://bugs.gentoo.org/889618
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the use of
+=operator with plain assignment to fix compatibility with shells other than bash. Without this script, the build fails on systems where /bin/sh is not bash (and e.g. dash).The original code leads to errors such as:
since the assignment is wrongly taken to be a command to execute. As a result, flags are not being appended and the build eventually fails with e.g.:
Original bug report: https://bugs.gentoo.org/889618