Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notification icon to every waybar config && fix view of tooltip #2021

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

KMohZaid
Copy link

@KMohZaid KMohZaid commented Nov 28, 2024

  1. I notice that notification icon was missing, when i read its module config i thought some bug. but it was because waybar config had it missing. (just 7th config had it)
  • I also put it ahead of backlight so it is easy to spot, for 11 to 14 config i put it ahead of privacy/battery

  1. Also the tooltip view was not proper so i fixed it little bit

Type of change

Please put an x in the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)

Checklist

Please put an x in the boxes that apply:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My commit message follows the commit guidelines.
  • I have added a changelog entry.
  • I have added necessary comments/documentation to my code.
  • I have tested my code locally and it works as expected.

Screenshots

Now it looks like :
241128_15h10m29s_screenshot
241128_15h36m39s_screenshot

@KMohZaid
Copy link
Author

  1. i didnt follow good commit message way, noob at it
  2. before it just displays body, but many notification passed summary section and skip body part
  • also message attribute is summary\nbody, i replacede \n with \n\n\t

@KMohZaid
Copy link
Author

also, i saw issue about widget notification center. until it is implemented. this is useful to avoid missing important notifcation

@KMohZaid
Copy link
Author

@kRHYME7 sorry to tag you but i guess you missed this

@kRHYME7
Copy link
Collaborator

kRHYME7 commented Dec 12, 2024

@rishav12s
Copy link
Contributor

@rubiin @rishav12s @mahaveergurjar @zeerayne

looks too long 💀💀

a tooltip covering an entire screen

this could be easily implemented by switching to swaync ig

@rubiin
Copy link
Contributor

rubiin commented Dec 12, 2024

This is something I have been working on my bar too lol

@KMohZaid
Copy link
Author

@rubiin @rishav12s @mahaveergurjar @zeerayne

looks too long 💀💀

a tooltip covering an entire screen

this could be easily implemented by switching to swaync ig

True, 😂

But it is just a work around to have better look from tooltip

Btw i switched to swaync the day i commented and mentioned kRHYME7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants