This repository has been archived by the owner on Apr 19, 2023. It is now read-only.
Feature/Bug Fix: Use exponential back off for gdrive download and gdrive download query #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@prasmussen please review, this seems to be a much sought after feature... |
euklid
changed the title
|
Can you also do it for upload? |
|
This should get implemented for every kind of download/upload/export operation. I need to export a bigger folder with |
|
@euklid tried yours but didn't work for me. Did I miss something? |
|
@jvfiel I don't have a need for this anymore, so I am sorry that I cannot provide any further help. |
msfjarvis
added a commit
to msfjarvis/gdrive
that referenced
this pull request
Nov 11, 2018
…wnload Feature/Bug Fix: Use exponential back off for gdrive download and gdrive download query * git://github.com/prasmussen/gdrive: Use exponential back off for gdrive download and gdrive download query
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exponential back off for
gdrive downloadandgdrive download query. Does not implement this for other parts, sorateLimit-like errors can still occur there, but I'm confident, it can be implemented there in a similar fashion.Uses an approach similar to
gdrive/drive/sync_upload.go
Line 273 in 9e8d2cd
The approach used is also referenced in #132 by @louiswilliams
This probably is a way towards a fix for #306 #132 and #272