Addressing requested changes

prebid · Mar 5, 2024 · 07acc54 · 07acc54
1 parent 3c57c36
commit 07acc54
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 10 deletions.
diff --git a/src/main/java/org/prebid/server/bidder/yieldlab/YieldlabBidder.java b/src/main/java/org/prebid/server/bidder/yieldlab/YieldlabBidder.java
@@ -52,7 +52,6 @@
 import java.util.Map;
 import java.util.Objects;
 import java.util.Optional;
-import java.util.function.Predicate;
 import java.util.stream.Collectors;
 
 public class YieldlabBidder implements Bidder<Void> {
@@ -250,7 +249,7 @@ private static Map<String, String> extractDsaRequestParamsFromBidRequest(BidRequ
             .map(Regs::getExt)
             .map(ExtRegs::getDsa)
             .map(YieldlabBidder::extractDsaRequestParamsFromDsaRegsExtension)
-            .orElse(Map.of());
+            .orElseGet(Map::of);
     }
 
     private static Map<String, String> extractDsaRequestParamsFromDsaRegsExtension(final ExtRegsDsa dsa) {
@@ -273,21 +272,18 @@ private static Map<String, String> extractDsaRequestParamsFromDsaRegsExtension(f
             dsaRequestParams.put("dsatransparency", encodeTransparenciesAsString(dsaTransparency));
         }
 
-        return dsaRequestParams.entrySet().stream()
-            .filter(entry -> !entry.getValue().isBlank())
-            .collect(Collectors.toMap(Map.Entry::getKey, Map.Entry::getValue));
+        return dsaRequestParams;
     }
 
     private static String encodeTransparenciesAsString(List<ExtRegsDsaTransparency> transparencies) {
         return transparencies.stream()
-            .filter(transparencyIsValid())
+            .filter(YieldlabBidder::transparencyIsValid)
             .map(YieldlabBidder::encodeTransparency)
             .collect(Collectors.joining(TRANSPARENCY_TEMPLATE_DELIMITER));
     }
 
-    private static Predicate<ExtRegsDsaTransparency> transparencyIsValid() {
-        return transparency ->
-            !Objects.isNull(transparency.getDomain())
+    private static boolean transparencyIsValid(ExtRegsDsaTransparency transparency) {
+        return transparency.getDomain() != null
                 && !Objects.isNull(transparency.getDsaParams())
                 && !transparency.getDsaParams().isEmpty();
     }

diff --git a/...main/java/org/prebid/server/bidder/yieldlab/model/YieldlabDigitalServicesActResponse.java b/...main/java/org/prebid/server/bidder/yieldlab/model/YieldlabDigitalServicesActResponse.java
@@ -18,7 +18,7 @@ public class YieldlabDigitalServicesActResponse {
     List<Transparency> transparency;
 
     @AllArgsConstructor(staticName = "of")
-    @Value
+    @Value(staticConstructor = "of")
     public static class Transparency {
         String domain;
         List<Integer> dsaparams;