Price Floors: Fix always inprogress bug (#1918)

prebid · Jun 23, 2022 · 4d241d2 · 4d241d2
1 parent 895b239
commit 4d241d2
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/main/java/org/prebid/server/floors/PriceFloorFetcher.java b/src/main/java/org/prebid/server/floors/PriceFloorFetcher.java
@@ -227,11 +227,12 @@ private PriceFloorData updateCache(ResponseCacheInfo cacheInfo,
         final AccountFetchContext fetchContext =
                 AccountFetchContext.of(cacheInfo.getRulesData(), cacheInfo.getFetchStatus(), maxAgeTimerId);
 
-        if (cacheInfo.getRulesData() != null || !fetchedData.containsKey(accountId)) {
+        if (cacheInfo.getFetchStatus() == FetchStatus.success || !fetchedData.containsKey(accountId)) {
             fetchedData.put(accountId, fetchContext);
-            fetchInProgress.remove(accountId);
         }
 
+        fetchInProgress.remove(accountId);
+
         return fetchContext.getRulesData();
     }
 

diff --git a/src/test/java/org/prebid/server/floors/PriceFloorFetcherTest.java b/src/test/java/org/prebid/server/floors/PriceFloorFetcherTest.java
@@ -75,7 +75,8 @@ public class PriceFloorFetcherTest extends VertxTest {
     @Before
     public void setUp() {
         debugProperties = new PriceFloorDebugProperties();
-        priceFloorFetcher = new PriceFloorFetcher(applicationSettings,
+        priceFloorFetcher = new PriceFloorFetcher(
+                applicationSettings,
                 metrics,
                 vertx,
                 timeoutFactory,