Improvedigital: Consent processor issue fix (#2954)

Co-authored-by: Mohammad Nurul Islam Shihan <islam.shihan@ext.azerion.dev>
prebid · Feb 14, 2024 · bb09799 · bb09799
1 parent 2322dfc
commit bb09799
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 2 deletions.
diff --git a/src/main/java/org/prebid/server/bidder/improvedigital/ImprovedigitalBidder.java b/src/main/java/org/prebid/server/bidder/improvedigital/ImprovedigitalBidder.java
@@ -98,8 +98,9 @@ private ExtUser getAdditionalConsentProvidersUserExt(ExtUser extUser) {
             return extUser;
         }
 
-        final String consentedProvidersPart = StringUtils.substringAfter(consentedProviders, "~");
-        if (StringUtils.isEmpty(consentedProvidersPart)) {
+        final String[] consentedProvidersParts = StringUtils.split(consentedProviders, "~");
+        final String consentedProvidersPart = consentedProvidersParts.length > 1 ? consentedProvidersParts[1] : null;
+        if (StringUtils.isBlank(consentedProvidersPart)) {
             return extUser;
         }
 

diff --git a/src/test/java/org/prebid/server/bidder/improvedigital/ImprovedigitalBidderTest.java b/src/test/java/org/prebid/server/bidder/improvedigital/ImprovedigitalBidderTest.java
@@ -141,6 +141,35 @@ public void makeHttpRequestsShouldProperProcessConsentedProvidersSetting() {
                 .containsExactly(expectedExtUser);
     }
 
+    @Test
+    public void makeHttpRequestsShouldProperProcessConsentedProvidersSettingWithMultipleTilda() {
+        // given
+        final ExtUser extUser = ExtUser.builder()
+                .consentedProvidersSettings(ConsentedProvidersSettings.of("1~10.20.90~anything"))
+                .build();
+
+        final BidRequest bidRequest = givenBidRequest(bidRequestBuilder -> bidRequestBuilder
+                .id("123")
+                .user(User.builder().ext(extUser).build())
+                .id("request_id"), identity());
+
+        // when
+        final Result<List<HttpRequest<BidRequest>>> result = target.makeHttpRequests(bidRequest);
+
+        // then
+        final ExtUser expectedExtUser = jacksonMapper.fillExtension(extUser,
+                mapper.createObjectNode().set("consented_providers_settings",
+                        mapper.createObjectNode()
+                                .set("consented_providers", mapper.createArrayNode().add(10).add(20).add(90))));
+
+        assertThat(result.getErrors()).isEmpty();
+        assertThat(result.getValue())
+                .extracting(HttpRequest::getPayload)
+                .extracting(BidRequest::getUser)
+                .extracting(User::getExt)
+                .containsExactly(expectedExtUser);
+    }
+
     @Test
     public void makeHttpRequestsShouldReturnUserExtIfConsentedProvidersIsNotProvided() {
         // given