Api field is not required for Video imp

prebid · Feb 1, 2024 · da8406b · da8406b
1 parent 5348d88
commit da8406b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/src/main/java/org/prebid/server/bidder/rubicon/RubiconBidder.java b/src/main/java/org/prebid/server/bidder/rubicon/RubiconBidder.java
@@ -1026,8 +1026,10 @@ private static ImpMediaType impType(Imp imp) {
 
     private static boolean isFullyPopulatedVideo(Video video) {
         // These are just recommended video fields for XAPI
-        return video.getMimes() != null && video.getProtocols() != null && video.getMaxduration() != null
-                && video.getLinearity() != null && video.getApi() != null;
+        return video.getMimes() != null
+                && video.getProtocols() != null
+                && video.getMaxduration() != null
+                && video.getLinearity() != null;
     }
 
     private static String referer(Site site) {

diff --git a/src/test/java/org/prebid/server/bidder/rubicon/RubiconBidderTest.java b/src/test/java/org/prebid/server/bidder/rubicon/RubiconBidderTest.java
@@ -715,7 +715,7 @@ public void makeHttpRequestsShouldCreateVideoRequestIfImpHasBannerAndVideoButAll
                 builder -> builder
                         .banner(Banner.builder().format(singletonList(Format.builder().w(300).h(250).build())).build())
                         .video(Video.builder().mimes(singletonList("mime1")).protocols(singletonList(1))
-                                .maxduration(60).linearity(2).api(singletonList(3)).build()),
+                                .maxduration(60).linearity(2).build()),
                 identity());
 
         // when
@@ -730,7 +730,7 @@ public void makeHttpRequestsShouldCreateVideoRequestIfImpHasBannerAndVideoButAll
                 .containsOnly(tuple(
                         null, // banner is removed
                         Video.builder().mimes(singletonList("mime1")).protocols(singletonList(1))
-                                .maxduration(60).linearity(2).api(singletonList(3)).build()));
+                                .maxduration(60).linearity(2).build()));
     }
 
     @Test
@@ -3295,7 +3295,6 @@ public void makeHttpRequestsShouldFillImpExtWithFloorsWhenBothVideoAndBanner() {
                                 .protocols(singletonList(1))
                                 .maxduration(10)
                                 .linearity(10)
-                                .api(singletonList(12))
                                 .build())
                         .banner(Banner.builder()
                                 .format(singletonList(Format.builder().h(300).w(250).build()))
@@ -3611,7 +3610,7 @@ public void makeBidsShouldReturnVideoBidIfRequestImpHasBannerAndVideoButAllRequi
                 givenBidRequest(builder -> builder
                         .banner(Banner.builder().build())
                         .video(Video.builder().mimes(singletonList("mime1")).protocols(singletonList(1))
-                                .maxduration(60).linearity(2).api(singletonList(3)).build())),
+                                .maxduration(60).linearity(2).build())),
                 givenBidResponse(ONE));
 
         // when