Fix comments

prebid · Oct 20, 2023 · e819130 · e819130
1 parent 7c11a10
commit e819130
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/main/java/org/prebid/server/bidder/huaweiads/HuaweiAdmBuilder.java b/src/main/java/org/prebid/server/bidder/huaweiads/HuaweiAdmBuilder.java
@@ -192,7 +192,7 @@ private static String makeUrl(MonitorEventType eventType, String url) {
             case CLICK -> "<ClickTracking><![CDATA[" + url + "]]></ClickTracking>";
             case IMP -> "<Impression><![CDATA[" + url + "]]></Impression>";
             case VAST_ERROR -> "<Error><![CDATA[" + url + "&et=[ERRORCODE]]]></Error>";
-            default -> "";
+            default -> StringUtils.EMPTY;
         };
     }
 
@@ -298,7 +298,7 @@ private static String makeDspClickTrackings(Content content) {
                         .filter(Objects::nonNull)
                         .map(tracking -> "\"" + tracking + "\"")
                         .collect(Collectors.joining(",")))
-                .orElse("");
+                .orElse(StringUtils.EMPTY);
     }
 
     private static String makeDspImpTrackings(Content content) {
@@ -312,7 +312,7 @@ private static String makeDspImpTrackings(Content content) {
                 .map(list -> list.stream()
                         .map(tracking -> "<img height=\"1\" width=\"1\" src='" + tracking + "' >  ")
                         .collect(Collectors.joining()))
-                .orElse("");
+                .orElse(StringUtils.EMPTY);
     }
 
     public HuaweiAdm buildNative(AdsType adType, Content content, Native xNative) {

diff --git a/src/main/java/org/prebid/server/bidder/huaweiads/HuaweiAdsBidder.java b/src/main/java/org/prebid/server/bidder/huaweiads/HuaweiAdsBidder.java
@@ -172,7 +172,7 @@ private Regs makeRegs(com.iab.openrtb.request.Regs regs) {
                 .map(com.iab.openrtb.request.Regs::getCoppa)
                 .filter(coppa -> coppa >= 0)
                 .map(Regs::of)
-                .orElse(Regs.of(null));
+                .orElseGet(() -> Regs.of(null));
     }
 
     private Geo makeGeo(com.iab.openrtb.request.Device device) {
@@ -349,7 +349,7 @@ private String getNurl(List<Monitor> monitorList) {
                 .map(Monitor::getUrlList)
                 .flatMap(Collection::stream)
                 .findFirst()
-                .orElse("");
+                .orElse(StringUtils.EMPTY);
     }
 
 }