Add product support for gumgum #2724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SerhiiNahornyi
suggested changes
Oct 26, 2023
src/main/java/org/prebid/server/bidder/gumgum/GumgumBidder.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
[INFO] Starting audit...
Error: /home/runner/work/prebid-server-java/prebid-server-java/src/main/java/org/prebid/server/bidder/gumgum/GumgumBidder.java:127: Line has trailing spaces. [RegexpSingleline]
Audit done.
You can check build locally by running mvn clean package -f extra even mvn clean package will be enough
SerhiiNahornyi
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IN this changes we will start to pass the product param from Prebid Server to GG Ad Server under the impressions.ext param.
For any questions/comments pls feel free to reach out
Thanks
Natalia Castiglioni