Rubicon: Adapter simplifications #2784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SerhiiNahornyi
changed the title
And1sS
requested changes
Nov 24, 2023
| final List<String> values = resolveSegtaxBlahValues(validDataSegments); | ||
| final ArrayNode segtaxBlah = target.putArray(SEGTAX_BLAH_ATTRIBUTE); | ||
| values.forEach(segtaxBlah::add); | ||
|
|
There was a problem hiding this comment.
Please, remove redundant empty line
And1sS
previously approved these changes
Nov 24, 2023
SerhiiNahornyi
force-pushed
the
rubicon-simplifications
branch
from
f184bca to
3c2c604
Compare
SerhiiNahornyi
added a commit
that referenced
this pull request
Nov 27, 2023
This reverts commit 4fa6ea5.
SerhiiNahornyi
added a commit
that referenced
this pull request
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.