Added usersyncers cookie-family-name property validation #2790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VeryExtraordinaryUsername
force-pushed
the
usersyncer_configs_validation
branch
from
337b584 to
303dbab
Compare
Net-burst
requested changes
Nov 23, 2023
Net-burst
reviewed
Nov 23, 2023
|
Good overall idea, but I don't like that there are a lot of jumps between List and Stream. This looks weird. |
VeryExtraordinaryUsername
force-pushed
the
usersyncer_configs_validation
branch
from
9ff57d8 to
0a28aaf
Compare
CTMBNara
reviewed
Nov 24, 2023
SerhiiNahornyi
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.