Add additional checks for only remove the transaction id from source obj if not present #2863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is false and supplyChainResolver can't resolve a schain for bidder
marki1an
requested changes
Jan 4, 2024
| @@ -646,6 +694,9 @@ class GppTransmitTidActivitiesSpec extends PrivacyBaseSpec { | |||
| !bidderRequest.imp[0].ext.tid | |||
| !bidderRequest.source.tid | |||
| } | |||
|
|
|||
| and: "Don’t affect source.schain if it was present" | |||
| bidderRequest.source.schain == sourceWithSchainAndTid.schain | |||
There was a problem hiding this comment.
Place assert before comparison, and at other places
…transaction-id-from-source-obj-if-not-present
…emove-the-transaction-id-from-source-obj-if-not-present' into functional-tests/S2S-1474-only-remove-the-transaction-id-from-source-obj-if-not-present
marki1an
previously approved these changes
Jan 8, 2024
| } | ||
|
|
||
| def "PBS amp should remove bidRequest.(source/imp[0].ext).tid when ext.prebid.createTids=null and defaultAction=false"() { | ||
| def "PBS amp should remove bidRequest.(source/imp[0].ext).tid but don't change schain in request when ext.prebid.createTids=#createTid and defaultAction=false"() { |
There was a problem hiding this comment.
#createTid still static, meaning null
PBS amp should remove bidRequest.(source/imp[0].ext).tid and don't change schain in request when ext.prebid.createTids=#createTid and defaultAction=false and schain specified in request
| where: | ||
| createTid << [true, null] | ||
| } | ||
|
|
||
| def "PBS auction should remove bidRequest.(source/imp[0].ext).tid when ext.prebid.createTids=null and activity disallowed"() { | ||
| given: "Bid requests with TID fields and account id" | ||
| def "PBS auction should remove bidRequest.(source/imp[0].ext).tid but don't change schain in request when ext.prebid.createTids=null and activity disallowed"() { |
There was a problem hiding this comment.
PBS auction should remove bidRequest.(source/imp[0].ext).tid and don't change schain in request when ext.prebid.createTids=null and activity disallowed
Please check other places.
marki1an
approved these changes
Jan 11, 2024
SerhiiNahornyi
deleted the
functional-tests/S2S-1474-only-remove-the-transaction-id-from-source-obj-if-not-present
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.