Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TransmitEids activity #2901

Merged
merged 31 commits into from
Mar 6, 2024
Merged

Add TransmitEids activity #2901

merged 31 commits into from
Mar 6, 2024

Conversation

CTMBNara
Copy link
Collaborator

@CTMBNara CTMBNara commented Jan 12, 2024

Purpose of this PR

  1. Refactoring
  2. Separate TransmitUfpd actiity to TransmitUfpd and TransmitEids
  3. Align TCF and activity controls

CTMBNara and others added 18 commits January 12, 2024 16:08
…ctivity

# Conflicts:
#	src/main/java/org/prebid/server/spring/config/PrivacyServiceConfiguration.java
#	src/test/java/org/prebid/server/auction/PrivacyEnforcementServiceTest.java
…ctivity

# Conflicts:
#	src/main/java/org/prebid/server/auction/ExchangeService.java
#	src/main/java/org/prebid/server/auction/PrivacyEnforcementService.java
#	src/main/java/org/prebid/server/auction/privacy/contextfactory/AmpPrivacyContextFactory.java
#	src/main/java/org/prebid/server/auction/requestfactory/VideoRequestFactory.java
#	src/main/java/org/prebid/server/spring/config/ServiceConfiguration.java
#	src/test/java/org/prebid/server/auction/PrivacyEnforcementServiceTest.java
#	src/test/java/org/prebid/server/auction/privacy/contextfactory/AmpPrivacyContextFactoryTest.java
#	src/test/java/org/prebid/server/handler/CookieSyncHandlerTest.java
…ctivity

# Conflicts:
#	extra/modules/confiant-ad-quality/src/test/java/org/prebid/server/hooks/modules/com/confiant/adquality/v1/ConfiantAdQualityBidResponsesScanHookTest.java
import groovy.transform.ToString

@ToString(includeNames = true, ignoreNulls = true)
@JsonNaming(PropertyNamingStrategies.SnakeCaseStrategy)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure that this should be snake_case? It's an account config, right? We were trying to have kebab-case for account config properties.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a requirement from issue

privacy.gdpr.purposes.p4.eid.require_consent: true/false  // if true, eids require P4 legal basis unless excepted below
privacy.gdpr.purposes.p4.eid.exceptions: ["pubcid.org"]   // doesn't do anything when eids-require-consent: false.

@osulzhenko osulzhenko force-pushed the add-transmit-eids-activity branch from 455b2f3 to 7262bff Compare March 6, 2024 12:21
@SerhiiNahornyi SerhiiNahornyi merged commit 3c63d78 into master Mar 6, 2024
5 checks passed
@SerhiiNahornyi SerhiiNahornyi deleted the add-transmit-eids-activity branch March 6, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants