Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rubicon: api field is not required for Video imp #2945

Merged
merged 1 commit into from
Feb 1, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -1026,8 +1026,10 @@ private static ImpMediaType impType(Imp imp) {

private static boolean isFullyPopulatedVideo(Video video) {
// These are just recommended video fields for XAPI
return video.getMimes() != null && video.getProtocols() != null && video.getMaxduration() != null
&& video.getLinearity() != null && video.getApi() != null;
return video.getMimes() != null
&& video.getProtocols() != null
&& video.getMaxduration() != null
&& video.getLinearity() != null;
}

private static String referer(Site site) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -715,7 +715,7 @@ public void makeHttpRequestsShouldCreateVideoRequestIfImpHasBannerAndVideoButAll
builder -> builder
.banner(Banner.builder().format(singletonList(Format.builder().w(300).h(250).build())).build())
.video(Video.builder().mimes(singletonList("mime1")).protocols(singletonList(1))
.maxduration(60).linearity(2).api(singletonList(3)).build()),
.maxduration(60).linearity(2).build()),
identity());

// when
Expand All @@ -730,7 +730,7 @@ public void makeHttpRequestsShouldCreateVideoRequestIfImpHasBannerAndVideoButAll
.containsOnly(tuple(
null, // banner is removed
Video.builder().mimes(singletonList("mime1")).protocols(singletonList(1))
.maxduration(60).linearity(2).api(singletonList(3)).build()));
.maxduration(60).linearity(2).build()));
}

@Test
Expand Down Expand Up @@ -3295,7 +3295,6 @@ public void makeHttpRequestsShouldFillImpExtWithFloorsWhenBothVideoAndBanner() {
.protocols(singletonList(1))
.maxduration(10)
.linearity(10)
.api(singletonList(12))
.build())
.banner(Banner.builder()
.format(singletonList(Format.builder().h(300).w(250).build()))
Expand Down Expand Up @@ -3611,7 +3610,7 @@ public void makeBidsShouldReturnVideoBidIfRequestImpHasBannerAndVideoButAllRequi
givenBidRequest(builder -> builder
.banner(Banner.builder().build())
.video(Video.builder().mimes(singletonList("mime1")).protocols(singletonList(1))
.maxduration(60).linearity(2).api(singletonList(3)).build())),
.maxduration(60).linearity(2).build())),
givenBidResponse(ONE));

// when
Expand Down
Loading