Geo Lookup Updates #3057
Merged
Geo Lookup Updates #3057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoxaAntoxic
commented
Mar 14, 2024
src/main/java/org/prebid/server/auction/privacy/contextfactory/AmpPrivacyContextFactory.java
Outdated
Show resolved
Hide resolved
AntoxaAntoxic
commented
Mar 14, 2024
src/main/java/org/prebid/server/deals/UserAdditionalInfoService.java
Outdated
Show resolved
Hide resolved
CTMBNara
requested changes
Mar 14, 2024
src/main/java/org/prebid/server/auction/GeoLocationServiceWrapper.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/auction/requestfactory/AmpRequestFactory.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/auction/requestfactory/Ortb2RequestFactory.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/auction/requestfactory/Ortb2RequestFactory.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/spring/config/GeoLocationConfiguration.java
Outdated
Show resolved
Hide resolved
CTMBNara
reviewed
Mar 14, 2024
| metrics.updateGeoLocationMetric(true); | ||
| final Boolean inEea = isCountryInEea(geoInfo.getCountry()); | ||
| private TcfContext enrichWithGeoInfo(TcfContext defaultTcfContext, GeoInfo geoInfo, String defaultCountry) { | ||
| final String country = ObjectUtil.getIfNotNullOrDefault(geoInfo, GeoInfo::getCountry, () -> defaultCountry); |
There was a problem hiding this comment.
Optional.ofNullable(geoInfo)
.map(GeoInfo::getCountry)
.orElse(defaultCountry)
CTMBNara
previously approved these changes
Mar 14, 2024
CTMBNara
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prebid/prebid-server#3392
prebid/prebid-server#3559