Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring functional tests #3657

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

osulzhenko
Copy link
Collaborator

@osulzhenko osulzhenko commented Jan 6, 2025

🔧 Type of changes

  • new bid adapter
  • bid adapter update
  • new feature
  • new analytics adapter
  • new module
  • module update
  • bugfix
  • documentation
  • configuration
  • dependency update
  • tech debt (test coverage, refactorings, etc.)

✨ What's the context?

What's the context for the changes?

🧠 Rationale behind the change

Why did you choose to make these changes? Were there any trade-offs you had to consider?

🔎 New Bid Adapter Checklist

  • verify email contact works
  • NO fully dynamic hostnames
  • geographic host parameters are NOT required
  • direct use of HTTP is prohibited - implement an existing Bidder interface that will do all the job
  • if the ORTB is just forwarded to the endpoint, use the generic adapter - define the new adapter as the alias of the generic adapter
  • cover an adapter configuration with an integration test

🧪 Test plan

How do you know the changes are safe to ship to production?

🏎 Quality check

  • Are your changes following our code style guidelines?
  • Are there any breaking changes in your code?
  • Does your test coverage exceed 90%?
  • Are there any erroneous console logs, debuggers or leftover code in your changes?

@osulzhenko osulzhenko added the tests Functional or other tests label Jan 6, 2025
@osulzhenko osulzhenko requested a review from marki1an January 6, 2025 08:07
@osulzhenko osulzhenko self-assigned this Jan 6, 2025
@osulzhenko osulzhenko marked this pull request as draft January 8, 2025 12:28
@osulzhenko osulzhenko force-pushed the refactoring-functional-tests branch from 6ad3b09 to 26f38ea Compare January 13, 2025 10:17
@osulzhenko osulzhenko force-pushed the refactoring-functional-tests branch from 26f38ea to c6ddf01 Compare January 14, 2025 09:36
# Conflicts:
#	src/test/groovy/org/prebid/server/functional/tests/AmpFpdSpec.groovy
@osulzhenko osulzhenko marked this pull request as ready for review January 14, 2025 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Functional or other tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant