Tests: Eidpermissions Request Validation Update #3688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marki1an
requested changes
Jan 22, 2025
| @@ -91,6 +94,58 @@ class EidsSpec extends BaseSpec { | |||
| assert !bidderRequest.user.eids | |||
| } | |||
|
|
|||
| def "PBS eids shouldn't include warning for unknown bidder in request"() { | |||
There was a problem hiding this comment.
PBS eids shouldn't include warning for unknown bidder when test and debug disabled
marki1an
requested changes
Jan 22, 2025
| def sourceId = PBSUtils.randomString | ||
| def eids = [new Eid(source: sourceId, uids: [new Uid(id: sourceId)])] | ||
| def bidRequest = BidRequest.defaultBidRequest.tap { | ||
| user = new User(eids: eids) |
There was a problem hiding this comment.
Add please to the test ext.eids = eids and for the second test too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
What's the context for the changes?
🧠 Rationale behind the change
Why did you choose to make these changes? Were there any trade-offs you had to consider?
🔎 New Bid Adapter Checklist
🧪 Test plan
How do you know the changes are safe to ship to production?
🏎 Quality check