Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Buyeruid scrubbed metric #3692

Open
wants to merge 1 commit into
base: buyeruid-scrubbed-metric
Choose a base branch
from

Conversation

marki1an
Copy link
Collaborator

@marki1an marki1an commented Jan 22, 2025

🔧 Type of changes

  • new bid adapter
  • bid adapter update
  • new feature
  • new analytics adapter
  • new module
  • module update
  • bugfix
  • documentation
  • configuration
  • dependency update
  • tech debt (test coverage, refactorings, etc.)

✨ What's the context?

What's the context for the changes?

🧠 Rationale behind the change

Why did you choose to make these changes? Were there any trade-offs you had to consider?

🔎 New Bid Adapter Checklist

  • verify email contact works
  • NO fully dynamic hostnames
  • geographic host parameters are NOT required
  • direct use of HTTP is prohibited - implement an existing Bidder interface that will do all the job
  • if the ORTB is just forwarded to the endpoint, use the generic adapter - define the new adapter as the alias of the generic adapter
  • cover an adapter configuration with an integration test

🧪 Test plan

How do you know the changes are safe to ship to production?

🏎 Quality check

  • Are your changes following our code style guidelines?
  • Are there any breaking changes in your code?
  • Does your test coverage exceed 90%?
  • Are there any erroneous console logs, debuggers or leftover code in your changes?

@marki1an marki1an self-assigned this Jan 22, 2025
@marki1an marki1an added the tests Functional or other tests label Jan 22, 2025
@osulzhenko osulzhenko self-requested a review January 22, 2025 14:46
Comment on lines +966 to +971
def tcfConsent = new TcfConsent.Builder().build()
def bidRequest = bidRequestWithPersonalData.tap {
regs.gdpr = 1
user.ext.consent = tcfConsent
ext.prebid.trace = VERBOSE
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

        def bidRequest = bidRequestWithPersonalData.tap {
            regs.gdpr = 1
            user.ext.consent = new TcfConsent.Builder().build()
            ext.prebid.trace = VERBOSE
        }

Comment on lines +1002 to +1003
assert metrics["adapter.${GENERIC.value}.requests.buyeruid_scrubbed"] == 1
assert metrics["account.${account.uuid}.adapter.${GENERIC.value}.requests.buyeruid_scrubbed"] == 1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls add case with basic verbosityLevel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Functional or other tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants