change getMediaTypeForBid(), use mtype to get bid type in response.

prebid · Jan 25, 2024 · ed5fec3 · ed5fec3
1 parent 188fcfc
commit ed5fec3
Show file tree

Hide file tree

Showing 6 changed files with 25 additions and 19 deletions.
diff --git a/adapters/adview/adview.go b/adapters/adview/adview.go
@@ -142,7 +142,7 @@ func (a *adapter) MakeBids(request *openrtb2.BidRequest, requestData *adapters.R
 	var errors []error
 	for _, seatBid := range response.SeatBid {
 		for i, bid := range seatBid.Bid {
-			bidType, err := getMediaTypeForBid(bid, request.Imp)
+			bidType, err := getMediaTypeForBid(bid)
 			if err != nil {
 				errors = append(errors, err)
 				continue
@@ -178,23 +178,19 @@ func getMediaTypeForImp(impID string, imps []openrtb2.Imp) (openrtb_ext.BidType,
 	return mediaType, nil
 }
 
-func getMediaTypeForBid(bid openrtb2.Bid, reqImps []openrtb2.Imp) (openrtb_ext.BidType, error) {
-	mediaType := openrtb_ext.BidTypeBanner
-	for _, imp := range reqImps {
-		if bid.ImpID == imp.ID {
-			if bid.Ext != nil {
-				var bidExt *adviewBidExt
-				err := json.Unmarshal(bid.Ext, &bidExt)
-				if err == nil {
-					return getBidType(bidExt)
-				} else {
-					return mediaType, err
-				}
-			}
-			return mediaType, nil
-		}
+func getMediaTypeForBid(bid openrtb2.Bid) (openrtb_ext.BidType, error) {
+	switch bid.MType {
+	case openrtb2.MarkupBanner:
+		return openrtb_ext.BidTypeBanner, nil
+	case openrtb2.MarkupVideo:
+		return openrtb_ext.BidTypeVideo, nil
+	case openrtb2.MarkupAudio:
+		return openrtb_ext.BidTypeAudio, nil
+	case openrtb2.MarkupNative:
+		return openrtb_ext.BidTypeNative, nil
+	default:
+		return "", fmt.Errorf("Unable to fetch mediaType in multi-format: %s", bid.ImpID)
 	}
-	return mediaType, nil
 }
 
 // getBidType returns the bid type specified in the response bid.ext

diff --git a/adapters/adview/adviewtest/exemplary/banner-app-format.json b/adapters/adview/adviewtest/exemplary/banner-app-format.json
@@ -116,6 +116,7 @@
                   "crid": "20",
                   "w": 320,
                   "h": 50,
+                  "mtype": 1,
                   "ext": {
                     "formattype": 0
                   }
@@ -152,6 +153,7 @@
             "crid": "20",
             "w": 320,
             "h": 50,
+            "mtype": 1,
             "ext": {
               "formattype": 0
             }

diff --git a/adapters/adview/adviewtest/exemplary/banner-app-resp-no-formattype.json b/adapters/adview/adviewtest/exemplary/banner-app-resp-no-formattype.json
@@ -105,7 +105,8 @@
                   ],
                   "crid": "20",
                   "w": 320,
-                  "h": 50
+                  "h": 50,
+                  "mtype": 1
                 }
               ],
               "type": "banner",
@@ -138,7 +139,8 @@
             ],
             "crid": "20",
             "w": 320,
-            "h": 50
+            "h": 50,
+            "mtype": 1
           },
           "type": "banner"
         }

diff --git a/adapters/adview/adviewtest/exemplary/banner-app.json b/adapters/adview/adviewtest/exemplary/banner-app.json
@@ -106,6 +106,7 @@
                   "crid": "20",
                   "w": 320,
                   "h": 50,
+                  "mtype": 1,
                   "ext": {
                     "formattype": 0
                   }
@@ -142,6 +143,7 @@
             "crid": "20",
             "w": 320,
             "h": 50,
+            "mtype": 1,
             "ext": {
               "formattype": 0
             }

diff --git a/adapters/adview/adviewtest/exemplary/native-app.json b/adapters/adview/adviewtest/exemplary/native-app.json
@@ -104,6 +104,7 @@
                     "awesome.com"
                   ],
                   "crid": "20",
+                  "mtype": 4,
                   "ext": {
                     "formattype": 2
                   }
@@ -135,6 +136,7 @@
             "price": 3.5,
             "adm": "awesome-markup",
             "crid": "20",
+            "mtype": 4,
             "adomain": [
               "awesome.com"
             ],

diff --git a/adapters/adview/adviewtest/exemplary/video-app.json b/adapters/adview/adviewtest/exemplary/video-app.json
@@ -116,6 +116,7 @@
                   "crid": "20",
                   "w": 1280,
                   "h": 720,
+                  "mtype": 2,
                   "ext": {
                     "formattype": 1
                   }
@@ -151,6 +152,7 @@
             ],
             "w": 1280,
             "h": 720,
+            "mtype": 2,
             "ext": {
               "formattype": 1
             }