Flipp: abide by privacy concerns when using flippExt userKey #3250

hasan-kanjee · 2023-10-23T18:23:07Z

Based on the discussion here prebid/prebid.github.io#4551 (comment), we will not use userKey from Flipp bidder params if any of the following conditions are true:

COPPA is in effect
The Global Privacy Control is set
TCF purpose 4 is in scope and doesn't have consent
The Prebid "transmitEids" activity is disallowed

github-actions · 2023-10-23T18:24:22Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 73182db

flipp

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/flipp/flipp.go:37:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/flipp/flipp.go:44:	MakeRequests		100.0%
github.com/prebid/prebid-server/v2/adapters/flipp/flipp.go:62:	makeRequest		75.0%
github.com/prebid/prebid-server/v2/adapters/flipp/flipp.go:81:	processImp		80.0%
github.com/prebid/prebid-server/v2/adapters/flipp/flipp.go:157:	buildPrebidRequest	100.0%
github.com/prebid/prebid-server/v2/adapters/flipp/flipp.go:174:	MakeBids		93.3%
github.com/prebid/prebid-server/v2/adapters/flipp/flipp.go:204:	getAdTypes		100.0%
github.com/prebid/prebid-server/v2/adapters/flipp/flipp.go:211:	buildBid		100.0%
github.com/prebid/prebid-server/v2/adapters/flipp/flipp.go:228:	paramsUserKeyPermitted	22.2%
total:								(statements)		77.1%

github-actions · 2023-10-23T21:17:04Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, e3ed794

flipp

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/flipp/flipp.go:37:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/flipp/flipp.go:44:	MakeRequests		100.0%
github.com/prebid/prebid-server/v2/adapters/flipp/flipp.go:62:	makeRequest		75.0%
github.com/prebid/prebid-server/v2/adapters/flipp/flipp.go:81:	processImp		80.0%
github.com/prebid/prebid-server/v2/adapters/flipp/flipp.go:157:	buildPrebidRequest	100.0%
github.com/prebid/prebid-server/v2/adapters/flipp/flipp.go:174:	MakeBids		93.3%
github.com/prebid/prebid-server/v2/adapters/flipp/flipp.go:204:	getAdTypes		100.0%
github.com/prebid/prebid-server/v2/adapters/flipp/flipp.go:211:	buildBid		100.0%
github.com/prebid/prebid-server/v2/adapters/flipp/flipp.go:228:	paramsUserKeyPermitted	88.9%
total:								(statements)		88.6%

onkarvhanumante · 2023-11-02T08:28:37Z

@hasan-kanjee

PBS-GO had a major release 2.0.0. Should update wishabi:OFF-658to be insync with prebid masterprebid:master

adapters/flipp/flipp.go

adapters/flipp/flipp_test.go

adapters/flipp/flipp.go

github-actions · 2023-11-05T02:43:40Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, bf826ae

flipp

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/flipp/flipp.go:47:	Generate		0.0%
github.com/prebid/prebid-server/v2/adapters/flipp/flipp.go:56:	Generate		100.0%
github.com/prebid/prebid-server/v2/adapters/flipp/flipp.go:60:	NewUUIDGenerator	66.7%
github.com/prebid/prebid-server/v2/adapters/flipp/flipp.go:69:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/flipp/flipp.go:76:	MakeRequests		100.0%
github.com/prebid/prebid-server/v2/adapters/flipp/flipp.go:94:	makeRequest		75.0%
github.com/prebid/prebid-server/v2/adapters/flipp/flipp.go:113:	processImp		88.6%
github.com/prebid/prebid-server/v2/adapters/flipp/flipp.go:190:	buildPrebidRequest	100.0%
github.com/prebid/prebid-server/v2/adapters/flipp/flipp.go:207:	MakeBids		93.3%
github.com/prebid/prebid-server/v2/adapters/flipp/flipp.go:237:	getAdTypes		100.0%
github.com/prebid/prebid-server/v2/adapters/flipp/flipp.go:244:	buildBid		100.0%
github.com/prebid/prebid-server/v2/adapters/flipp/flipp.go:261:	paramsUserKeyPermitted	88.9%
total:								(statements)		90.0%

github-actions · 2023-11-05T02:52:54Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, f8a96e2

flipp

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/flipp/flipp.go:45:	Generate		0.0%
github.com/prebid/prebid-server/v2/adapters/flipp/flipp.go:51:	Generate		100.0%
github.com/prebid/prebid-server/v2/adapters/flipp/flipp.go:55:	NewUUIDGenerator	66.7%
github.com/prebid/prebid-server/v2/adapters/flipp/flipp.go:64:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/flipp/flipp.go:71:	MakeRequests		100.0%
github.com/prebid/prebid-server/v2/adapters/flipp/flipp.go:89:	makeRequest		75.0%
github.com/prebid/prebid-server/v2/adapters/flipp/flipp.go:108:	processImp		88.6%
github.com/prebid/prebid-server/v2/adapters/flipp/flipp.go:185:	buildPrebidRequest	100.0%
github.com/prebid/prebid-server/v2/adapters/flipp/flipp.go:202:	MakeBids		93.3%
github.com/prebid/prebid-server/v2/adapters/flipp/flipp.go:232:	getAdTypes		100.0%
github.com/prebid/prebid-server/v2/adapters/flipp/flipp.go:239:	buildBid		100.0%
github.com/prebid/prebid-server/v2/adapters/flipp/flipp.go:256:	paramsUserKeyPermitted	88.9%
total:								(statements)		90.0%

hasan-kanjee · 2023-11-05T02:55:52Z

@hasan-kanjee

PBS-GO had a major release 2.0.0. Should update wishabi:OFF-658to be insync with prebid masterprebid:master

@onkarvhanumante I am not sure what I need to update here exactly? Is there some documentation that describes what needs to be updated for our adapter?

github-actions · 2023-11-06T14:57:59Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, acd47e5

flipp

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/flipp/flipp.go:42:	Generate		0.0%
github.com/prebid/prebid-server/v2/adapters/flipp/flipp.go:47:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/flipp/flipp.go:55:	MakeRequests		100.0%
github.com/prebid/prebid-server/v2/adapters/flipp/flipp.go:73:	makeRequest		75.0%
github.com/prebid/prebid-server/v2/adapters/flipp/flipp.go:92:	processImp		88.6%
github.com/prebid/prebid-server/v2/adapters/flipp/flipp.go:169:	buildPrebidRequest	100.0%
github.com/prebid/prebid-server/v2/adapters/flipp/flipp.go:186:	MakeBids		93.3%
github.com/prebid/prebid-server/v2/adapters/flipp/flipp.go:216:	getAdTypes		100.0%
github.com/prebid/prebid-server/v2/adapters/flipp/flipp.go:223:	buildBid		100.0%
github.com/prebid/prebid-server/v2/adapters/flipp/flipp.go:240:	paramsUserKeyPermitted	89.5%
total:								(statements)		90.7%

github-actions · 2023-11-06T17:19:10Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 1da6935

flipp

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/flipp/flipp.go:44:	Generate		0.0%
github.com/prebid/prebid-server/v2/adapters/flipp/flipp.go:49:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/flipp/flipp.go:57:	MakeRequests		100.0%
github.com/prebid/prebid-server/v2/adapters/flipp/flipp.go:75:	makeRequest		75.0%
github.com/prebid/prebid-server/v2/adapters/flipp/flipp.go:94:	processImp		88.6%
github.com/prebid/prebid-server/v2/adapters/flipp/flipp.go:171:	buildPrebidRequest	100.0%
github.com/prebid/prebid-server/v2/adapters/flipp/flipp.go:188:	MakeBids		93.3%
github.com/prebid/prebid-server/v2/adapters/flipp/flipp.go:218:	getAdTypes		100.0%
github.com/prebid/prebid-server/v2/adapters/flipp/flipp.go:225:	buildBid		100.0%
github.com/prebid/prebid-server/v2/adapters/flipp/flipp.go:242:	paramsUserKeyPermitted	80.0%
total:								(statements)		89.0%

adapters/flipp/flipp.go

go.mod

github-actions · 2023-11-09T14:30:33Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, a304f2e

flipp

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/flipp/flipp.go:41:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/flipp/flipp.go:49:	MakeRequests		100.0%
github.com/prebid/prebid-server/v2/adapters/flipp/flipp.go:67:	makeRequest		75.0%
github.com/prebid/prebid-server/v2/adapters/flipp/flipp.go:86:	processImp		88.6%
github.com/prebid/prebid-server/v2/adapters/flipp/flipp.go:163:	buildPrebidRequest	100.0%
github.com/prebid/prebid-server/v2/adapters/flipp/flipp.go:180:	MakeBids		93.3%
github.com/prebid/prebid-server/v2/adapters/flipp/flipp.go:210:	getAdTypes		100.0%
github.com/prebid/prebid-server/v2/adapters/flipp/flipp.go:217:	buildBid		100.0%
github.com/prebid/prebid-server/v2/adapters/flipp/flipp.go:234:	paramsUserKeyPermitted	80.0%
total:								(statements)		89.8%

adapters/flipp/flipp.go

hasan-kanjee · 2023-11-17T18:43:56Z

@onkarvhanumante any update on getting this merged?

onkarvhanumante · 2023-11-20T06:20:25Z

@onkarvhanumante any update on getting this merged?

thanks for your patience. A lot of PRs were on hold while we worked to release v2.0.0. Now that it has been released, we've resumed work on open PRs. thanks for your patience. A lot of PRs were on hold while we worked to release v2.0.0. Now that it has been released, we've resumed work on open PRs.

…3250)

OFF-658 abide by privacy concerns when using flippExt userKey

73182db

add tests

e3ed794

Sonali-More-Xandr assigned onkarvhanumante and Sonali-More-Xandr Oct 31, 2023

onkarvhanumante reviewed Nov 2, 2023

View reviewed changes

adapters/flipp/flipp.go Outdated Show resolved Hide resolved

onkarvhanumante reviewed Nov 2, 2023

View reviewed changes

adapters/flipp/flipp_test.go Outdated Show resolved Hide resolved

onkarvhanumante reviewed Nov 2, 2023

View reviewed changes

adapters/flipp/flipp_test.go Outdated Show resolved Hide resolved

onkarvhanumante reviewed Nov 2, 2023

View reviewed changes

adapters/flipp/flipp.go Show resolved Hide resolved

onkarvhanumante reviewed Nov 2, 2023

View reviewed changes

adapters/flipp/flipp.go Outdated Show resolved Hide resolved

onkarvhanumante reviewed Nov 2, 2023

View reviewed changes

adapters/flipp/flipp.go Outdated Show resolved Hide resolved

add additional tests and minor code fixes

f8a96e2

hasan-kanjee force-pushed the OFF-658 branch from bf826ae to f8a96e2 Compare November 5, 2023 02:51

fix to ensure generate uid is working

acd47e5

use go-gdpr instead of iabtcfv2

1da6935

onkarvhanumante reviewed Nov 8, 2023

View reviewed changes

adapters/flipp/flipp.go Outdated Show resolved Hide resolved

onkarvhanumante reviewed Nov 8, 2023

View reviewed changes

go.mod Outdated Show resolved Hide resolved

use uuidutil

a304f2e

onkarvhanumante reviewed Nov 10, 2023

View reviewed changes

adapters/flipp/flipp.go Show resolved Hide resolved

onkarvhanumante approved these changes Nov 14, 2023

View reviewed changes

Sonali-More-Xandr approved these changes Nov 20, 2023

View reviewed changes

Sonali-More-Xandr merged commit cad9097 into prebid:master Nov 20, 2023
5 checks passed

cross-repo-issue-creation bot mentioned this pull request Nov 20, 2023

Port PR from PBS-Go: Flipp: abide by privacy concerns when using flippExt userKey prebid/prebid-server-java#2774

Closed

svamiftah pushed a commit to sovrn/prebid-server that referenced this pull request Nov 21, 2023

Flipp: abide by privacy concerns when using flippExt userKey (prebid#…

5842581

…3250)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Flipp: abide by privacy concerns when using flippExt userKey #3250

Flipp: abide by privacy concerns when using flippExt userKey #3250

hasan-kanjee commented Oct 23, 2023

github-actions bot commented Oct 23, 2023

github-actions bot commented Oct 23, 2023

onkarvhanumante commented Nov 2, 2023

github-actions bot commented Nov 5, 2023

github-actions bot commented Nov 5, 2023

hasan-kanjee commented Nov 5, 2023

github-actions bot commented Nov 6, 2023

github-actions bot commented Nov 6, 2023

github-actions bot commented Nov 9, 2023

hasan-kanjee commented Nov 17, 2023

onkarvhanumante commented Nov 20, 2023

Flipp: abide by privacy concerns when using flippExt userKey #3250

Flipp: abide by privacy concerns when using flippExt userKey #3250

Conversation

hasan-kanjee commented Oct 23, 2023

github-actions bot commented Oct 23, 2023

Code coverage summary

flipp

github-actions bot commented Oct 23, 2023

Code coverage summary

flipp

onkarvhanumante commented Nov 2, 2023

github-actions bot commented Nov 5, 2023

Code coverage summary

flipp

github-actions bot commented Nov 5, 2023

Code coverage summary

flipp

hasan-kanjee commented Nov 5, 2023

github-actions bot commented Nov 6, 2023

Code coverage summary

flipp

github-actions bot commented Nov 6, 2023

Code coverage summary

flipp

github-actions bot commented Nov 9, 2023

Code coverage summary

flipp

hasan-kanjee commented Nov 17, 2023

onkarvhanumante commented Nov 20, 2023