Bizzclick: adapter update, add new host param #3347

BizzClick · 2023-12-12T16:42:54Z

Hi, the adapter was updated with new sourceId and host params.
Related PR in prebid.github.io

github-actions · 2023-12-12T16:43:43Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 95c41ac

bizzclick

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/bizzclick/bizzclick.go:21:	Builder				100.0%
github.com/prebid/prebid-server/v2/adapters/bizzclick/bizzclick.go:33:	getHeaders			100.0%
github.com/prebid/prebid-server/v2/adapters/bizzclick/bizzclick.go:56:	MakeRequests			83.3%
github.com/prebid/prebid-server/v2/adapters/bizzclick/bizzclick.go:89:	getImpressionExt		85.7%
github.com/prebid/prebid-server/v2/adapters/bizzclick/bizzclick.go:106:	buildEndpointURL		100.0%
github.com/prebid/prebid-server/v2/adapters/bizzclick/bizzclick.go:115:	checkResponseStatusCodes	100.0%
github.com/prebid/prebid-server/v2/adapters/bizzclick/bizzclick.go:137:	MakeBids			100.0%
github.com/prebid/prebid-server/v2/adapters/bizzclick/bizzclick.go:183:	getMediaTypeForImp		100.0%
total:									(statements)			96.0%

bretg · 2023-12-14T21:01:54Z

As noted in the docs PR, asking for publishers to enter the geographic region is not the right way to do this.

For Prebid.js, you really ought to be paying for a global traffic management solution.
For Prebid Server, a solution is to have the host company deploy a different endpoint in different regions. See #3311

Since the host parameter is optional, I won't insist, but I'm going to request that you consider how difficult it might be for a publisher to carry out this request.

BizzClick · 2023-12-15T11:47:53Z

@bretg We're using it because we have different regions/datacenters of our servers. For instance US East and Europe regions, such parameter would be useful to reduce network latency.
I any case, we can receive traffic to our US servers from anywhere, but it would be preferable to get to the appropriate region

bretg · 2023-12-15T14:17:39Z

because we have different regions/datacenters of our servers

Many of us are in that situation that's not the problem. The problem is in how you're asking publishers to choose the region. That places an undue (often impossible) burden on them.

Copying what was said above:

For Prebid.js, you really ought to be paying for a global traffic management solution.

Many vendors offer such solutions. Search for "gslb solutions"

For Prebid Server, a solution is to have the host company deploy a different endpoint in different regions. See #3311

Please consider updating your bizzclick.yaml file similar to the rubicon.yaml there. https://github.com/prebid/prebid-server/pull/3311/files#diff-8fc6fb8199a8e0dcf5c4a887cf074043b99af8fdb349c2176ae5644e13a35ecc . You can your host param as a default if you'd like, though you can see here that Rubicon insists that PBS host companies make the choice based per-datacenter.

BizzClick · 2023-12-18T14:25:45Z

@bretg I will add geoscope to .yaml file. But I think in our case it would be better to give us the right to chose. We're providing to publishers our fixed host parameter with the rest of params. So we can't let give a right to chose region for publisher, because due to internal settings of exchange each publisher is tied to its own region, though we can change it, but we would like to avoid that

github-actions · 2023-12-18T14:29:02Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 97cc6d7

bizzclick

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/bizzclick/bizzclick.go:21:	Builder				100.0%
github.com/prebid/prebid-server/v2/adapters/bizzclick/bizzclick.go:33:	getHeaders			100.0%
github.com/prebid/prebid-server/v2/adapters/bizzclick/bizzclick.go:56:	MakeRequests			83.3%
github.com/prebid/prebid-server/v2/adapters/bizzclick/bizzclick.go:89:	getImpressionExt		85.7%
github.com/prebid/prebid-server/v2/adapters/bizzclick/bizzclick.go:106:	buildEndpointURL		100.0%
github.com/prebid/prebid-server/v2/adapters/bizzclick/bizzclick.go:115:	checkResponseStatusCodes	100.0%
github.com/prebid/prebid-server/v2/adapters/bizzclick/bizzclick.go:137:	MakeBids			100.0%
github.com/prebid/prebid-server/v2/adapters/bizzclick/bizzclick.go:183:	getMediaTypeForImp		100.0%
total:									(statements)			96.0%

bretg · 2023-12-18T15:53:48Z

each publisher is tied to its own region

To be honest, I find it quite unfriendly to make publishers enter this static parameter on every adunit for architecture reasons. But as long as host is not a required param, we will tolerate it.

github-actions · 2023-12-19T17:57:57Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, b07eb3e

bizzclick

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/bizzclick/bizzclick.go:21:	Builder				100.0%
github.com/prebid/prebid-server/v2/adapters/bizzclick/bizzclick.go:33:	getHeaders			100.0%
github.com/prebid/prebid-server/v2/adapters/bizzclick/bizzclick.go:56:	MakeRequests			83.3%
github.com/prebid/prebid-server/v2/adapters/bizzclick/bizzclick.go:89:	getImpressionExt		85.7%
github.com/prebid/prebid-server/v2/adapters/bizzclick/bizzclick.go:106:	buildEndpointURL		100.0%
github.com/prebid/prebid-server/v2/adapters/bizzclick/bizzclick.go:115:	checkResponseStatusCodes	100.0%
github.com/prebid/prebid-server/v2/adapters/bizzclick/bizzclick.go:137:	MakeBids			100.0%
github.com/prebid/prebid-server/v2/adapters/bizzclick/bizzclick.go:183:	getMediaTypeForImp		100.0%
total:									(statements)			96.0%

BizzClick · 2023-12-19T17:58:13Z

@bretg Ok, I'll keep host parameter and I've updated bizzclick.yaml according to your previous messages. Let me know if it fits

onkarvhanumante · 2024-01-09T12:20:46Z

static/bidder-params/bizzclick.json

-    "placementId": {
+    "sourceId": {
      "type": "string",
-      "description": "PlacementId id",
+      "description": "Source id",
+      "minLength": 1
+    },
+    "host": {
+      "type": "string",
+      "description": "Server region",
      "minLength": 1
    }
  },
-  "required": ["accountId", "placementId"]
+  "required": [
+    "accountId",
+    "sourceId"
+  ]


@BizzClick , placementId was required param and PR is renaming placementId to sourceId.

This will be an breaking change for the publishers making call to adapter. Should consider a transition period before making such change. Transition period will give provide enough time for the publishers and PBS host compaines to accomadate for such change.

As of now,

will recommend to keep placementId and mark it as deprecated in bidder docs. Alsoto anyone as shown below for required params

"oneOf": [ { "required": ["accountId", "placementId"] }, { "required": ["accountId", "sourceId"] } ]

Refer below example for deprecating placementId

prebid-server/static/bidder-params/rise.json

Lines 11 to 14 in 2c3ec84

"publisher_id": {

"type": "string",

"description": "Deprecated, use org instead."

}

Adapter code can be changed to use one of sourceId or placementId

All right, that looks reasonable. Fixed in the last commit

Related commit in doc

openrtb_ext/imp_bizzclick.go

onkarvhanumante · 2024-01-09T12:26:03Z

adapters/bizzclick/bizzclick.go

+	host := "us-e-node1"
+	if params.Host != "" {
+		host = params.Host
+	}


should add/ update test where params.Host is empty

The test was added here:
adapters/bizzclick/bizzclicktest/exemplary/default-host-param.json
With the placementId param also

github-actions · 2024-01-15T12:50:37Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 16bd598

bizzclick

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/bizzclick/bizzclick.go:21:	Builder				100.0%
github.com/prebid/prebid-server/v2/adapters/bizzclick/bizzclick.go:33:	getHeaders			100.0%
github.com/prebid/prebid-server/v2/adapters/bizzclick/bizzclick.go:56:	MakeRequests			83.3%
github.com/prebid/prebid-server/v2/adapters/bizzclick/bizzclick.go:89:	getImpressionExt		85.7%
github.com/prebid/prebid-server/v2/adapters/bizzclick/bizzclick.go:106:	buildEndpointURL		100.0%
github.com/prebid/prebid-server/v2/adapters/bizzclick/bizzclick.go:119:	checkResponseStatusCodes	100.0%
github.com/prebid/prebid-server/v2/adapters/bizzclick/bizzclick.go:141:	MakeBids			100.0%
github.com/prebid/prebid-server/v2/adapters/bizzclick/bizzclick.go:187:	getMediaTypeForImp		100.0%
total:									(statements)			96.2%

BizzClick added 2 commits December 8, 2023 17:11

update bizzclick adapter with new params

720f847

fix

95c41ac

BizzClick mentioned this pull request Dec 12, 2023

Bizzclick: update doc prebid/prebid.github.io#5026

Merged

9 tasks

added geoscope to yaml file

97cc6d7

gargcreation1992 assigned gargcreation1992 and onkarvhanumante Dec 18, 2023

update bizzclick yaml with geographic scope

b07eb3e

onkarvhanumante reviewed Jan 9, 2024

View reviewed changes

openrtb_ext/imp_bizzclick.go Outdated Show resolved Hide resolved

onkarvhanumante reviewed Jan 9, 2024

View reviewed changes

add deprecated placementId param & host param test

16bd598

gargcreation1992 approved these changes Jan 17, 2024

View reviewed changes

onkarvhanumante approved these changes Jan 17, 2024

View reviewed changes

gargcreation1992 merged commit 6195581 into prebid:master Jan 18, 2024
5 checks passed

cross-repo-issue-creation bot mentioned this pull request Jan 18, 2024

Port PR from PBS-Go: Bizzclick: adapter update, add new host param prebid/prebid-server-java#2912

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bizzclick: adapter update, add new host param #3347

Bizzclick: adapter update, add new host param #3347

BizzClick commented Dec 12, 2023 •

edited

Loading

github-actions bot commented Dec 12, 2023

bretg commented Dec 14, 2023

BizzClick commented Dec 15, 2023

bretg commented Dec 15, 2023

BizzClick commented Dec 18, 2023

github-actions bot commented Dec 18, 2023

bretg commented Dec 18, 2023

github-actions bot commented Dec 19, 2023

BizzClick commented Dec 19, 2023

onkarvhanumante Jan 9, 2024 •

edited

Loading

BizzClick Jan 15, 2024

BizzClick Jan 15, 2024

onkarvhanumante Jan 9, 2024

BizzClick Jan 15, 2024

github-actions bot commented Jan 15, 2024

	"publisher_id": {
	"type": "string",
	"description": "Deprecated, use org instead."
	}

Bizzclick: adapter update, add new host param #3347

Bizzclick: adapter update, add new host param #3347

Conversation

BizzClick commented Dec 12, 2023 • edited Loading

github-actions bot commented Dec 12, 2023

Code coverage summary

bizzclick

bretg commented Dec 14, 2023

BizzClick commented Dec 15, 2023

bretg commented Dec 15, 2023

BizzClick commented Dec 18, 2023

github-actions bot commented Dec 18, 2023

Code coverage summary

bizzclick

bretg commented Dec 18, 2023

github-actions bot commented Dec 19, 2023

Code coverage summary

bizzclick

BizzClick commented Dec 19, 2023

onkarvhanumante Jan 9, 2024 • edited Loading

Choose a reason for hiding this comment

BizzClick Jan 15, 2024

Choose a reason for hiding this comment

BizzClick Jan 15, 2024

Choose a reason for hiding this comment

onkarvhanumante Jan 9, 2024

Choose a reason for hiding this comment

BizzClick Jan 15, 2024

Choose a reason for hiding this comment

github-actions bot commented Jan 15, 2024

Code coverage summary

bizzclick

BizzClick commented Dec 12, 2023 •

edited

Loading

onkarvhanumante Jan 9, 2024 •

edited

Loading