Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Adapter: zMaticoo #3349

Merged
merged 25 commits into from
Jan 22, 2024
Merged

New Adapter: zMaticoo #3349

merged 25 commits into from
Jan 22, 2024

Conversation

lxj15398019970
Copy link
Contributor

zMaticoo is the advanced advertising platform offering programmatic solutions launched by eclicktech , driven by innovation and artificial intelligence technology, connects buyers and media channels through data in real time

this is zmaticoo adapter version 1.0

Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 46927d7

zmaticoo

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:23:	Builder		100.0%
github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:35:	MakeRequests	100.0%
github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:46:	makeRequest	78.6%
github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:76:	transform	93.8%
github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:104:	getZmaticooExt	100.0%
github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:127:	getEndpoint	100.0%
github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:132:	MakeBids	100.0%
github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:170:	getBidType	100.0%
total:									(statements)	95.1%

@bsardo bsardo changed the title new adapter for zmaticoo New Adapter: zMaticoo Dec 13, 2023
@lxj15398019970
Copy link
Contributor Author

Please review these code and merge to the master~

Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, bee679f

yeahmobi

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/yeahmobi/yeahmobi.go:23:	Builder		100.0%
github.com/prebid/prebid-server/v2/adapters/yeahmobi/yeahmobi.go:35:	MakeRequests	100.0%
github.com/prebid/prebid-server/v2/adapters/yeahmobi/yeahmobi.go:46:	makeRequest	78.6%
github.com/prebid/prebid-server/v2/adapters/yeahmobi/yeahmobi.go:76:	transform	93.8%
github.com/prebid/prebid-server/v2/adapters/yeahmobi/yeahmobi.go:104:	getYeahmobiExt	100.0%
github.com/prebid/prebid-server/v2/adapters/yeahmobi/yeahmobi.go:127:	getEndpoint	100.0%
github.com/prebid/prebid-server/v2/adapters/yeahmobi/yeahmobi.go:132:	MakeBids	73.1%
github.com/prebid/prebid-server/v2/adapters/yeahmobi/yeahmobi.go:186:	getBidType	100.0%
total:									(statements)	88.2%

zmaticoo

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:23:	Builder		100.0%
github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:35:	MakeRequests	100.0%
github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:46:	makeRequest	78.6%
github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:76:	transform	93.8%
github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:104:	getZmaticooExt	100.0%
github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:127:	getEndpoint	100.0%
github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:132:	MakeBids	100.0%
github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:170:	getBidType	100.0%
total:									(statements)	95.1%

Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 005bd14

yeahmobi

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/yeahmobi/yeahmobi.go:23:	Builder		100.0%
github.com/prebid/prebid-server/v2/adapters/yeahmobi/yeahmobi.go:35:	MakeRequests	100.0%
github.com/prebid/prebid-server/v2/adapters/yeahmobi/yeahmobi.go:46:	makeRequest	78.6%
github.com/prebid/prebid-server/v2/adapters/yeahmobi/yeahmobi.go:76:	transform	93.8%
github.com/prebid/prebid-server/v2/adapters/yeahmobi/yeahmobi.go:104:	getYeahmobiExt	100.0%
github.com/prebid/prebid-server/v2/adapters/yeahmobi/yeahmobi.go:127:	getEndpoint	100.0%
github.com/prebid/prebid-server/v2/adapters/yeahmobi/yeahmobi.go:132:	MakeBids	73.1%
github.com/prebid/prebid-server/v2/adapters/yeahmobi/yeahmobi.go:186:	getBidType	100.0%
total:									(statements)	88.2%

zmaticoo

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:23:	Builder		100.0%
github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:35:	MakeRequests	100.0%
github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:46:	makeRequest	78.6%
github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:76:	transform	93.8%
github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:104:	getZmaticooExt	100.0%
github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:127:	getEndpoint	100.0%
github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:132:	MakeBids	100.0%
github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:170:	getBidType	100.0%
total:									(statements)	95.1%

Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 490db00

yeahmobi

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/yeahmobi/yeahmobi.go:23:	Builder		100.0%
github.com/prebid/prebid-server/v2/adapters/yeahmobi/yeahmobi.go:35:	MakeRequests	100.0%
github.com/prebid/prebid-server/v2/adapters/yeahmobi/yeahmobi.go:46:	makeRequest	78.6%
github.com/prebid/prebid-server/v2/adapters/yeahmobi/yeahmobi.go:76:	transform	93.8%
github.com/prebid/prebid-server/v2/adapters/yeahmobi/yeahmobi.go:104:	getYeahmobiExt	100.0%
github.com/prebid/prebid-server/v2/adapters/yeahmobi/yeahmobi.go:127:	getEndpoint	100.0%
github.com/prebid/prebid-server/v2/adapters/yeahmobi/yeahmobi.go:132:	MakeBids	73.1%
github.com/prebid/prebid-server/v2/adapters/yeahmobi/yeahmobi.go:186:	getBidType	100.0%
total:									(statements)	88.2%

zmaticoo

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:23:	Builder		100.0%
github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:35:	MakeRequests	100.0%
github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:46:	makeRequest	78.6%
github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:76:	transform	93.8%
github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:104:	getZmaticooExt	100.0%
github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:127:	getEndpoint	100.0%
github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:132:	MakeBids	100.0%
github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:170:	getBidType	100.0%
total:									(statements)	95.1%

Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 1423f1b

yeahmobi

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/yeahmobi/yeahmobi.go:23:	Builder		100.0%
github.com/prebid/prebid-server/v2/adapters/yeahmobi/yeahmobi.go:35:	MakeRequests	100.0%
github.com/prebid/prebid-server/v2/adapters/yeahmobi/yeahmobi.go:46:	makeRequest	78.6%
github.com/prebid/prebid-server/v2/adapters/yeahmobi/yeahmobi.go:76:	transform	93.8%
github.com/prebid/prebid-server/v2/adapters/yeahmobi/yeahmobi.go:104:	getYeahmobiExt	100.0%
github.com/prebid/prebid-server/v2/adapters/yeahmobi/yeahmobi.go:127:	getEndpoint	100.0%
github.com/prebid/prebid-server/v2/adapters/yeahmobi/yeahmobi.go:132:	MakeBids	73.1%
github.com/prebid/prebid-server/v2/adapters/yeahmobi/yeahmobi.go:186:	getBidType	100.0%
total:									(statements)	88.2%

zmaticoo

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:23:	Builder		100.0%
github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:35:	MakeRequests	100.0%
github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:46:	makeRequest	78.6%
github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:76:	transform	93.8%
github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:104:	getZmaticooExt	100.0%
github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:127:	getEndpoint	100.0%
github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:132:	MakeBids	100.0%
github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:170:	getBidType	100.0%
total:									(statements)	95.1%

Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 7961562

yeahmobi

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/yeahmobi/yeahmobi.go:23:	Builder		100.0%
github.com/prebid/prebid-server/v2/adapters/yeahmobi/yeahmobi.go:35:	MakeRequests	100.0%
github.com/prebid/prebid-server/v2/adapters/yeahmobi/yeahmobi.go:46:	makeRequest	78.6%
github.com/prebid/prebid-server/v2/adapters/yeahmobi/yeahmobi.go:76:	transform	93.8%
github.com/prebid/prebid-server/v2/adapters/yeahmobi/yeahmobi.go:104:	getYeahmobiExt	100.0%
github.com/prebid/prebid-server/v2/adapters/yeahmobi/yeahmobi.go:127:	getEndpoint	100.0%
github.com/prebid/prebid-server/v2/adapters/yeahmobi/yeahmobi.go:132:	MakeBids	73.1%
github.com/prebid/prebid-server/v2/adapters/yeahmobi/yeahmobi.go:186:	getBidType	100.0%
total:									(statements)	88.2%

zmaticoo

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:23:	Builder		100.0%
github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:35:	MakeRequests	100.0%
github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:46:	makeRequest	78.6%
github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:76:	transform	93.8%
github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:104:	getZmaticooExt	100.0%
github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:127:	getEndpoint	100.0%
github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:132:	MakeBids	100.0%
github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:170:	getBidType	100.0%
total:									(statements)	95.1%

Copy link
Contributor

@onkarvhanumante onkarvhanumante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lxj15398019970 added few comments.

Additionally requesting to address previously opened comments

Copy link

github-actions bot commented Jan 9, 2024

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 2faafd5

zmaticoo

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:19:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:25:	MakeRequests		100.0%
github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:34:	makeRequest		83.3%
github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:57:	transform		88.9%
github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:86:	getZmaticooExt		87.5%
github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:111:	MakeBids		88.2%
github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:142:	getMediaTypeForBid	80.0%
total:									(statements)		87.7%

Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, b002d76

zmaticoo

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:19:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:25:	MakeRequests		100.0%
github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:34:	makeRequest		83.3%
github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:57:	transform		88.9%
github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:86:	getZmaticooExt		100.0%
github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:111:	MakeBids		88.2%
github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:142:	getMediaTypeForBid	80.0%
total:									(statements)		90.4%

Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 3448c3a

zmaticoo

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:19:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:25:	MakeRequests		100.0%
github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:34:	makeRequest		83.3%
github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:57:	transform		88.9%
github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:84:	getZmaticooExt		100.0%
github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:109:	MakeBids		88.2%
github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:140:	getMediaTypeForBid	80.0%
total:									(statements)		90.4%

Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 2873dad

zmaticoo

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:19:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:25:	MakeRequests		100.0%
github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:34:	makeRequest		83.3%
github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:57:	transform		88.9%
github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:84:	getZmaticooExt		100.0%
github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:109:	MakeBids		88.2%
github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:140:	getMediaTypeForBid	80.0%
total:									(statements)		90.4%

Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, d23bab2

zmaticoo

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:19:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:25:	MakeRequests		100.0%
github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:34:	makeRequest		83.3%
github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:57:	transform		88.2%
github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:82:	getZmaticooExt		100.0%
github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:107:	MakeBids		88.2%
github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:138:	getMediaTypeForBid	80.0%
total:									(statements)		90.3%

Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, adc564c

zmaticoo

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:19:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:25:	MakeRequests		100.0%
github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:34:	makeRequest		83.3%
github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:57:	transform		88.2%
github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:82:	validateZmaticooExt	100.0%
github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:107:	MakeBids		88.2%
github.com/prebid/prebid-server/v2/adapters/zmaticoo/zmaticoo.go:138:	getMediaTypeForBid	80.0%
total:									(statements)		90.3%

@lxj15398019970
Copy link
Contributor Author

@gargcreation1992 Can you help me review the code?

@gargcreation1992 gargcreation1992 merged commit b806a53 into prebid:master Jan 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants