New Adapter: AdUp Tech #4076

danygielow · 2024-11-26T07:34:10Z

Hello,

We as AdUp Technology want to add our own Prebid Server Adapter.
We already have a PrebidJS Adapter.

github-actions · 2024-11-26T07:34:50Z

adapters/aduptech/aduptech.go

+}
+
+func getBidType(markupType openrtb2.MarkupType) (openrtb_ext.BidType, error) {
+	switch markupType {


Consider this as a suggestion. The current implementation follows an anti-pattern, assumes that if there is a multi-format request, the media type defaults to openrtb_ext.BidTypeBanner. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, we strongly recommend implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.

github-actions · 2024-11-26T07:34:51Z

adapters/aduptech/aduptech.go

+}
+
+func getBidType(markupType openrtb2.MarkupType) (openrtb_ext.BidType, error) {
+	switch markupType {


Consider this as a suggestion. The current implementation follows an anti-pattern, assumes that if there is a multi-format request, the media type defaults to openrtb_ext.BidTypeNative. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, we strongly recommend implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.

github-actions · 2024-11-26T07:34:56Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 74112fe

aduptech

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/aduptech/aduptech.go:23:	Builder		100.0%
github.com/prebid/prebid-server/v3/adapters/aduptech/aduptech.go:32:	MakeRequests	53.8%
github.com/prebid/prebid-server/v3/adapters/aduptech/aduptech.go:63:	convertCurrency	0.0%
github.com/prebid/prebid-server/v3/adapters/aduptech/aduptech.go:90:	MakeBids	63.6%
github.com/prebid/prebid-server/v3/adapters/aduptech/aduptech.go:136:	getBidType	75.0%
total:									(statements)	49.1%

github-actions · 2024-11-27T06:32:57Z

adapters/aduptech/aduptech.go

+}
+
+func getBidType(markupType openrtb2.MarkupType) (openrtb_ext.BidType, error) {
+	switch markupType {


Consider this as a suggestion. The current implementation follows an anti-pattern, assumes that if there is a multi-format request, the media type defaults to openrtb_ext.BidTypeBanner. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, we strongly recommend implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.

github-actions · 2024-11-27T06:32:58Z

adapters/aduptech/aduptech.go

+}
+
+func getBidType(markupType openrtb2.MarkupType) (openrtb_ext.BidType, error) {
+	switch markupType {


Consider this as a suggestion. The current implementation follows an anti-pattern, assumes that if there is a multi-format request, the media type defaults to openrtb_ext.BidTypeNative. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, we strongly recommend implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.

What should be changed here? I assume this check is wrong, because we do exactly what the comment suggests.

💯 this suggestion (x3?) is not very helpful

I'm not sure why this is triggering but you can ignore it.

github-actions · 2024-11-27T06:33:05Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 8e94b4b

aduptech

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/aduptech/aduptech.go:23:	Builder		100.0%
github.com/prebid/prebid-server/v3/adapters/aduptech/aduptech.go:32:	MakeRequests	84.6%
github.com/prebid/prebid-server/v3/adapters/aduptech/aduptech.go:63:	convertCurrency	75.0%
github.com/prebid/prebid-server/v3/adapters/aduptech/aduptech.go:90:	MakeBids	63.6%
github.com/prebid/prebid-server/v3/adapters/aduptech/aduptech.go:136:	getBidType	75.0%
total:									(statements)	73.6%

bsardo · 2025-01-06T16:46:56Z

@scr-oath can you please review?

bsardo · 2025-01-07T16:20:08Z

@pm-isha-bharti can you please review?

scr-oath · 2025-01-07T19:24:57Z

adapters/aduptech/aduptech.go

+func Builder(bidderName openrtb_ext.BidderName, config config.Adapter, server config.Server) (adapters.Bidder, error) {
+	bidder := &adapter{
+		endpoint:        config.Endpoint,
+		target_currency: "EUR",


question: Can this go into ExtraAdapterInfo (either directly or as json that's parsed or inspected maybe with gjson.Get) rather than being hard coded?

Changed to use ExtraAdapterInfo.

scr-oath · 2025-01-07T19:28:26Z

adapters/aduptech/aduptech.go

+
+			convertedValue, err := a.convertCurrency(imp.BidFloor, imp.BidFloorCur, reqInfo)
+			if err != nil {
+				return nil, err


suggestion: This return doesn't seem right - as it should be []error - perhaps, if convertCurrency returns a []error, it should be named errs rather than err which suggests a single error as the type.

convertCurrency doesn't have to return []error. Refactored to just return a single error.

scr-oath · 2025-01-07T19:29:03Z

adapters/aduptech/aduptech.go

+	}
+
+	requestData := &adapters.RequestData{
+		Method: "POST",


Suggested change

Method: "POST",

Method: http.MethodPost,

scr-oath · 2025-01-07T19:56:59Z

adapters/aduptech/aduptech.go

+
+			// try again by first converting to USD
+			// then convert to target_currency
+			convertedValue, err = reqInfo.ConvertCurrency(value, cur, "USD")


observation we should have constants or an enum of valid currencies… you can ignore for this PR but just making the note; filed #4134

scr-oath · 2025-01-07T20:42:16Z

adapters/aduptech/aduptech.go

+	if responseData.StatusCode == http.StatusNoContent {
+		return nil, nil
+	}
+
+	if responseData.StatusCode == http.StatusBadRequest {
+		err := &errortypes.BadInput{
+			Message: "Unexpected status code: 400. Run with request.debug = 1 for more info.",
+		}
+		return nil, []error{err}
+	}
+
+	if responseData.StatusCode != http.StatusOK {
+		err := &errortypes.BadServerResponse{
+			Message: fmt.Sprintf("Unexpected status code: %d. Run with request.debug = 1 for more info.", responseData.StatusCode),
+		}
+		return nil, []error{err}
+	}


question: would a switch on the statusCode (with empty for ok and default clause for this everything-else case) be more readable?

Refactored into a switch

scr-oath · 2025-01-07T20:46:18Z

adapters/aduptech/aduptech.go

+	for _, seatBid := range response.SeatBid {
+		for i, bid := range seatBid.Bid {
+			bidType, err := getBidType(bid.MType)
+			if err != nil {
+				errs = append(errs, err)
+				continue
+			}
+
+			bidResponse.Bids = append(bidResponse.Bids, &adapters.TypedBid{
+				Bid:     &seatBid.Bid[i],
+				BidType: bidType,
+			})
+		}
+	}


suggestion: I don't like making copies of the seatbid and bid in a loop

Suggested change

for _, seatBid := range response.SeatBid {

for i, bid := range seatBid.Bid {

bidType, err := getBidType(bid.MType)

if err != nil {

errs = append(errs, err)

continue

}

bidResponse.Bids = append(bidResponse.Bids, &adapters.TypedBid{

Bid: &seatBid.Bid[i],

BidType: bidType,

})

}

}

for i := range response.SeatBid {

seatBid = &response.SeatBid[i]

for j := range seatBid.Bid {

bid := &seatBid.Bid[j]

bidType, err := getBidType(bid.MType)

if err != nil {

errs = append(errs, err)

continue

}

bidResponse.Bids = append(bidResponse.Bids, &adapters.TypedBid{

Bid: bid,

BidType: bidType,

})

}

}

Used your suggestion

scr-oath · 2025-01-07T20:48:00Z

adapters/aduptech/aduptech.go

+}
+
+func getBidType(markupType openrtb2.MarkupType) (openrtb_ext.BidType, error) {
+	switch markupType {


💯 this suggestion (x3?) is not very helpful

scr-oath · 2025-01-07T20:48:45Z

adapters/aduptech/aduptech_test.go

+	if buildErr != nil {
+		t.Fatalf("Builder returned unexpected error %v", buildErr)
+	}


Suggested change

if buildErr != nil {

t.Fatalf("Builder returned unexpected error %v", buildErr)

}

if buildErr != nil {

assert.NoError(t, buildErr, "Builder returned unexpected error")

}

Ah, good to know. This is our first time working in Go.

suggestion: Change assert to require

For what it's worth, I realize you were calling fatal before so I realize you need the require.NoError - assertions from the assert module continue but the test fails whereas those from require halt immediately. This is kind of like google's gtest with its two variants for each assertion so when you can continue you report more/all things that fail but when you can't, you don't.

scr-oath · 2025-01-07T20:49:54Z

adapters/aduptech/params_test.go

+		if err := validator.Validate(openrtb_ext.BidderAdUpTech, json.RawMessage(invalidParam)); err == nil {
+			t.Errorf("Schema allowed unexpected params: %s", invalidParam)
+		}


Suggested change

if err := validator.Validate(openrtb_ext.BidderAdUpTech, json.RawMessage(invalidParam)); err == nil {

t.Errorf("Schema allowed unexpected params: %s", invalidParam)

}

assert.NoErrorf(t, validator.Validate(openrtb_ext.BidderAdUpTech, json.RawMessage(invalidParam)), "Schema allowed unexpected params: %s", invalidParam)

using assert.Errorf here, but otherwise used the suggestion.

scr-oath

I didn't mean to approve before… I thought I had ticked request changes…

github-actions · 2025-01-08T07:55:13Z

adapters/aduptech/aduptech.go

+}
+
+func getBidType(markupType openrtb2.MarkupType) (openrtb_ext.BidType, error) {
+	switch markupType {


Consider this as a suggestion. The current implementation follows an anti-pattern, assumes that if there is a multi-format request, the media type defaults to openrtb_ext.BidTypeBanner. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, we strongly recommend implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.

github-actions · 2025-01-08T07:55:14Z

adapters/aduptech/aduptech.go

+}
+
+func getBidType(markupType openrtb2.MarkupType) (openrtb_ext.BidType, error) {
+	switch markupType {


Consider this as a suggestion. The current implementation follows an anti-pattern, assumes that if there is a multi-format request, the media type defaults to openrtb_ext.BidTypeNative. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, we strongly recommend implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.

github-actions · 2025-01-08T07:55:37Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 2ad858d

aduptech

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/aduptech/aduptech.go:27:	Builder		80.0%
github.com/prebid/prebid-server/v3/adapters/aduptech/aduptech.go:41:	MakeRequests	84.6%
github.com/prebid/prebid-server/v3/adapters/aduptech/aduptech.go:72:	convertCurrency	75.0%
github.com/prebid/prebid-server/v3/adapters/aduptech/aduptech.go:99:	MakeBids	71.4%
github.com/prebid/prebid-server/v3/adapters/aduptech/aduptech.go:145:	getBidType	75.0%
total:									(statements)	76.4%

pm-isha-bharti · 2025-01-08T08:35:54Z

static/bidder-info/aduptech.yaml

+      - banner
+      - native
+userSync:
+  redirect:


@danygielow The usersync URL returned by the /cookie_sync for aduptech is currently throwing 404. Can you please check if the URLs added for userSync are correct?

Fixed sync Endpoint.

Verified redirect works with id set in cookie:

pm-isha-bharti · 2025-01-08T09:19:19Z

adapters/aduptech/aduptech.go

+func (a *adapter) MakeBids(request *openrtb2.BidRequest, requestData *adapters.RequestData, responseData *adapters.ResponseData) (*adapters.BidderResponse, []error) {
+	switch responseData.StatusCode {
+	case http.StatusNoContent:
+		return nil, nil


Please add a supplemental JSON test where your mock response returns a 204 status code.

pm-isha-bharti · 2025-01-08T09:22:19Z

adapters/aduptech/aduptech.go

+
+	var response openrtb2.BidResponse
+	if err := jsonutil.Unmarshal(responseData.Body, &response); err != nil {
+		return nil, []error{err}


Please add a supplemental JSON test where your mock response returns a bid response that fails to unmarshal successfully. This can be achieved by setting one of the fields to an incorrect data type.

pm-isha-bharti · 2025-01-08T09:24:49Z

adapters/aduptech/aduptech.go

+	switch responseData.StatusCode {
+	case http.StatusNoContent:
+		return nil, nil
+	case http.StatusBadRequest:


Please add a supplemental JSON test where your mock response returns a 400 status code.

pm-isha-bharti · 2025-01-08T10:50:50Z

adapters/aduptech/aduptech.go

+func (a *adapter) convertCurrency(value float64, cur string, reqInfo *adapters.ExtraRequestInfo) (float64, error) {
+	convertedValue, err := reqInfo.ConvertCurrency(value, cur, a.extraInfo.TargetCurrency)
+
+	if err != nil {


Please add supplemental JSONs for currency conversion failures

scr-oath · 2025-01-08T15:57:44Z

adapters/aduptech/aduptech_test.go

+	bidder, buildErr := Builder(openrtb_ext.BidderAdUpTech, config.Adapter{
+		Endpoint: "https://example.com/rtb/bid", ExtraAdapterInfo: "{\"target_currency\": \"EUR\"}"}, config.Server{ExternalUrl: "http://hosturl.com", GvlID: 1, DataCenter: "2"})
+
+	assert.NoError(t, buildErr, "Builder returned unexpected error")


Suggested change

assert.NoError(t, buildErr, "Builder returned unexpected error")

require.NoError(t, buildErr, "Builder returned unexpected error")

scr-oath · 2025-01-08T15:58:01Z

adapters/aduptech/aduptech_test.go

+package aduptech
+
+import (
+	"github.com/stretchr/testify/assert"


Suggested change

"github.com/stretchr/testify/assert"

"github.com/stretchr/testify/assert"

"github.com/stretchr/testify/require"

scr-oath · 2025-01-08T15:58:46Z

adapters/aduptech/params_test.go

+	}
+
+	for _, validParam := range validParams {
+		assert.NoErrorf(t, validator.Validate(openrtb_ext.BidderAdUpTech, json.RawMessage(validParam)), "Schema rejected Aduptech params: %s", validParam)


FWIW, assert seems correct here as you want all failing assertions reported

bsardo · 2025-01-08T18:34:00Z

Hi @danygielow, @derfryday, now that the review process has begun, can you please push new commits when making changes instead of rebasing and force pushing? It will save reviewers a lot of time when performing delta reviews. All of the commits will be squashed when we merge. Thanks!

scr-oath · 2025-01-09T04:28:07Z

adapters/aduptech/aduptech.go

+func Builder(bidderName openrtb_ext.BidderName, config config.Adapter, server config.Server) (adapters.Bidder, error) {
+	var extraInfo ExtraInfo
+	if err := jsonutil.Unmarshal([]byte(config.ExtraAdapterInfo), &extraInfo); err != nil {
+		return nil, fmt.Errorf("invalid extra info: %v", err)


suggestion: Use %w instead - see https://pkg.go.dev/fmt#Errorf

Suggested change

return nil, fmt.Errorf("invalid extra info: %v", err)

return nil, fmt.Errorf("invalid extra info: %w", err)

Changed to %w

scr-oath · 2025-01-09T04:39:47Z

adapters/aduptech/aduptech.go

+				return nil, []error{err}
+			}
+
+			imp.BidFloorCur = a.extraInfo.TargetCurrency


bug?: There seems like a bug in here somewhere… the convertCurrency has a path that can handle errors and, instead, convert to "USD" - how is that choice made here if you always set the BidFloorCur to a.extraInfo.TargetCurrency - should you pass in a pointer to the extraInfo and set the chosen currency in the convertCurrency method maybe? or return the choice back and set to that? Style is your choice, but I think that's an unhandled case and might deserve some unit tests to prove it works as intended.

Hi, we try to be ready for the eventuality of conversion rates to EUR not being there for every currency.

The process is:

first try to convert directly to EUR

if there is an error, check if it is a conversion rate error

if it is, try converting to USD first and then from USD to EUR

So if convertCurrency is successful, then the BidFloorCur is EUR.

There are already special currency conversion JSON tests. See exemplary/simple-banner-convert-currency.json and exemplary/simple-banner-convert-currency-intermediate.json.

oh… so it won't convert to USD and return no error - it would try to go from USD to EUR and return that result - therefore, the err != nil would save setting blindly to TargetCurrency even if USD were chosen; thanks

scr-oath · 2025-01-09T04:43:43Z

adapters/aduptech/aduptech.go

+
+	if err != nil {
+		var convErr currency.ConversionNotFoundError
+		if errors.As(err, &convErr) {


nitpick/suggestion: In go, there's a pattern that you try to take the "terminal" case first - return/break/panic/exit so that you don't need an else clause - it saves "cognitive overload" because you can just reason that everything after is the "happy path" (not having your brain full with remembering what the condition was when you get to the else way down the screen or having to scroll back up to understand it) - and also saves precious indentation 😄

(so make this !errors.As and pull the else clause into the block and remove the curly braces {} (keeping and unindenting this code))

Changed, to have the terminal case first.

pm-isha-bharti · 2025-01-10T07:08:42Z

openrtb_ext/imp_aduptech.go

+	Publisher string          `json:"publisher"`
+	Placement string          `json:"placement"`
+	Query     string          `json:"query"`
+	AdTest    string          `json:"adtest"`


Can we use bidrequest.test instead of introducing a separate parameter, considering it is a standard ORTB field already used by Prebid?

Hi,

Unfortunately, we already have this parameter in the Prebid JS Adapter.
See: https://github.com/prebid/prebid.github.io/blob/master/dev-docs/bidders/aduptech.md?plain=1#L26

…sible, fixed sync URL

github-actions · 2025-01-13T12:44:29Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 4f3580c

aduptech

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/aduptech/aduptech.go:27:	Builder		85.7%
github.com/prebid/prebid-server/v3/adapters/aduptech/aduptech.go:45:	MakeRequests	84.6%
github.com/prebid/prebid-server/v3/adapters/aduptech/aduptech.go:80:	convertCurrency	75.0%
github.com/prebid/prebid-server/v3/adapters/aduptech/aduptech.go:106:	MakeBids	100.0%
github.com/prebid/prebid-server/v3/adapters/aduptech/aduptech.go:152:	getBidType	100.0%
total:									(statements)	89.5%

github-actions · 2025-01-13T13:07:05Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 1dc4b16

aduptech

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/aduptech/aduptech.go:27:	Builder		85.7%
github.com/prebid/prebid-server/v3/adapters/aduptech/aduptech.go:45:	MakeRequests	92.3%
github.com/prebid/prebid-server/v3/adapters/aduptech/aduptech.go:80:	convertCurrency	83.3%
github.com/prebid/prebid-server/v3/adapters/aduptech/aduptech.go:106:	MakeBids	100.0%
github.com/prebid/prebid-server/v3/adapters/aduptech/aduptech.go:152:	getBidType	100.0%
total:									(statements)	93.0%

scr-oath · 2025-01-13T16:47:45Z

adapters/aduptech/aduptech_test.go

+	bidder, buildErr := Builder(openrtb_ext.BidderAdUpTech, config.Adapter{
+		Endpoint: "https://example.com/rtb/bid", ExtraAdapterInfo: "{\"target_currency\": \"EUR\"}"}, config.Server{ExternalUrl: "http://hosturl.com", GvlID: 1, DataCenter: "2"})


suggestion: json can be easier to read/maintain if using the backtick string literal as long as the data doesn't contain backtick, which should be uncommon. (See https://go.dev/ref/spec#String_literals). Also… a few newlines couldn't hurt here to line up the fields so you can tell what goes with what at a glance:

Suggested change

bidder, buildErr := Builder(openrtb_ext.BidderAdUpTech, config.Adapter{

Endpoint: "https://example.com/rtb/bid", ExtraAdapterInfo: "{\"target_currency\": \"EUR\"}"}, config.Server{ExternalUrl: "http://hosturl.com", GvlID: 1, DataCenter: "2"})

bidder, buildErr := Builder(

openrtb_ext.BidderAdUpTech,

config.Adapter{

Endpoint: "https://example.com/rtb/bid",

ExtraAdapterInfo: `{"target_currency": "EUR"}`,

},

config.Server{

ExternalUrl: "http://hosturl.com",

GvlID: 1,

DataCenter: "2",

},

)

There are other places where this pattern can improve readability; I've only exemplified this one.

OK, sorry, i thought gofmt takes care of everything. I didn't even try to format anything.
I come from Python where black or now ruff-format will also take care of line breaks and indentations in appropriate places to improve readability. And they reference gofmt as an inspiration.

github-actions · 2025-01-16T06:02:01Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, ec665c1

aduptech

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/aduptech/aduptech.go:27:	Builder		85.7%
github.com/prebid/prebid-server/v3/adapters/aduptech/aduptech.go:45:	MakeRequests	92.3%
github.com/prebid/prebid-server/v3/adapters/aduptech/aduptech.go:80:	convertCurrency	83.3%
github.com/prebid/prebid-server/v3/adapters/aduptech/aduptech.go:106:	MakeBids	100.0%
github.com/prebid/prebid-server/v3/adapters/aduptech/aduptech.go:152:	getBidType	100.0%
total:									(statements)	93.0%

danygielow · 2025-01-21T08:35:34Z

@scr-oath The checks seem to have problems. Can you please take a look.

scr-oath · 2025-01-21T15:37:27Z

@scr-oath The checks seem to have problems. Can you please take a look.

Hmm… I still see checks running and none of the completed ones have failed - ~~will check back when those finish~~ Seems ok to me:

scr-oath · 2025-01-21T17:38:53Z

adapters/aduptech/aduptech.go

+	}
+
+	if extraInfo.TargetCurrency == "" {
+		return nil, fmt.Errorf("invalid extra info: TargetCurrency is empty, pls check")


nitpick (not-blocking) while a little pedantic, I prefer errors.New for errors that are just string literals.

Suggested change

return nil, fmt.Errorf("invalid extra info: TargetCurrency is empty, pls check")

return nil, errors.New("invalid extra info: TargetCurrency is empty, pls check")

Good catch, agreed @scr-oath.

makes sense, changed it

bsardo · 2025-01-21T17:11:51Z

openrtb_ext/imp_aduptech.go

+	Publisher string          `json:"publisher"`
+	Placement string          `json:"placement"`
+	Query     string          `json:"query"`
+	AdTest    string          `json:"adtest"`


I understand that this data structure is not being used but please make it match what you've defined in your bidder params JSON file so that it contains all of the parameters you've defined there and have corresponding Go types. In that case you should add a bool debug field and adtest should be bool.

bsardo · 2025-01-21T17:15:08Z

static/bidder-info/aduptech.yaml

@@ -0,0 +1,27 @@
+endpoint: "https://rtb.d.adup-tech.com/rtb/bid"


Confirmed endpoint is reachable:

curl -i --location --request POST https://rtb.d.adup-tech.com/rtb/bid HTTP/2 200 date: Tue, 21 Jan 2025 17:14:24 GMT content-type: application/json content-length: 87 server: nginx {"error":"Could not determine network. Publisher is missing in request parameters. {}"}

bsardo · 2025-01-21T17:16:39Z

static/bidder-info/aduptech.yaml

+  - CHE
+  - GBR
+maintainer:
+  email: "support@adup-tech.com"


We've sent an email to this address. Please respond with a message of "Received" to confirm it is active.

👍 email received.

bsardo · 2025-01-21T17:20:39Z

static/bidder-info/aduptech.yaml

+  - GBR
+maintainer:
+  email: "support@adup-tech.com"
+gvlVendorID: 647


GVL Vendor ID looks correct:

curl https://vendor-list.consensu.org/v3/vendor-list.json | jq '.vendors."647"' % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 656k 100 656k 0 0 4138k 0 --:--:-- --:--:-- --:--:-- 4156k { "id": 647, "name": "Axel Springer Teaser Ad GmbH", "purposes": [ 1, 3, 4, 5, 6 ], "legIntPurposes": [ 2, 7, 10, 11 ], "flexiblePurposes": [ 2, 7, 10, 11 ], "specialPurposes": [ 1, 2, 3 ], "features": [ 3 ], "specialFeatures": [], "cookieMaxAgeSeconds": 31536000, "usesCookies": true, "cookieRefresh": true, "urls": [ { "langId": "en", "privacy": "https://www.adup-tech.com/en/privacy-policy/", "legIntClaim": "https://www.adup-tech.com/en/privacy-policy/#c4489" }, { "langId": "de", "privacy": "https://www.adup-tech.com/rechtliches/datenschutz/", "legIntClaim": "https://www.adup-tech.com/rechtliches/datenschutz/#c4488" } ], "usesNonCookieAccess": true, "dataRetention": { "stdRetention": 365, "purposes": {}, "specialPurposes": {} }, "dataDeclaration": [ 1, 2, 3, 6, 8, 10, 11 ], "deviceStorageDisclosureUrl": "https://s.d.adup-tech.com/gdpr/deviceStorage.json" }

bsardo · 2025-01-21T17:29:52Z

static/bidder-info/aduptech.yaml

+  iframe:
+    url: "https://rtb.d.adup-tech.com/service/sync?iframe=1&gdpr={{.GDPR}}&gdpr_consent={{.GDPRConsent}}&us_privacy={{.USPrivacy}}&redirect={{.RedirectURL}}"
+    userMacro: "[UID]"


Verified iframe works with id set in cookie:

bsardo · 2025-01-21T17:46:05Z

adapters/aduptech/params_test.go

+
+var validParams = []string{
+	`{ "publisher": "123456789", "placement": "234567890" }`,
+	`{ "publisher": "123456789", "placement": "234567890", "query": "test" }`,


According to your bidder params JSON file, your string params publisher, placement and query are considered valid if they are specified as empty strings. Please add a test case for this.

added minLength to publisher and placement, added more params tests

bsardo · 2025-01-21T17:52:20Z

adapters/aduptech/aduptech.go

+		if !errors.As(err, &convErr) {
+			return 0, err
+		}


Please add a supplemental JSON test case where imp[].bidfloorcur is invalid to cover this block.

bsardo · 2025-01-21T17:54:05Z

adapters/aduptech/aduptech.go

+		if err != nil {
+			return 0, err
+		}


Please add a supplemental JSON test case where ext.prebid.currency.rates contains an invalid USD conversion to cover this block:
e.g.

"USD": { "INVALID": 2.0 }

The currency rates are already validated before the json test runs.
See: https://github.com/prebid/prebid-server/blob/master/adapters/adapterstest/test_json.go#L149

bsardo · 2025-01-21T19:16:06Z

adapters/aduptech/aduptech.go

+	switch responseData.StatusCode {
+	case http.StatusNoContent:
+		return nil, nil
+	case http.StatusBadRequest:
+		return nil, []error{&errortypes.BadInput{
+			Message: "Unexpected status code: 400. Run with request.debug = 1 for more info.",
+		}}
+	case http.StatusOK:
+		// we don't need to do anything here and this is just so we can use the default case for the unexpected status code
+		break
+	default:
+		return nil, []error{&errortypes.BadServerResponse{
+			Message: fmt.Sprintf("Unexpected status code: %d.", responseData.StatusCode),
+		}}
+
+	}


Please use the adapter utility functions IsResponseStatusCodeNoContent and CheckResponseStatusCodeForErrors found in adapters/response.go for processing the http status code.

now using the utility functions

bsardo · 2025-01-21T19:25:51Z

adapters/aduptech/aduptech.go

+}
+
+func getBidType(markupType openrtb2.MarkupType) (openrtb_ext.BidType, error) {
+	switch markupType {


I'm not sure why this is triggering but you can ignore it.

…StatusCodeForErrors to check response status codes

…int to publisher and placement param, added params tests

github-actions · 2025-01-22T12:37:18Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 8315a50

aduptech

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/aduptech/aduptech.go:27:	Builder		85.7%
github.com/prebid/prebid-server/v3/adapters/aduptech/aduptech.go:45:	MakeRequests	92.3%
github.com/prebid/prebid-server/v3/adapters/aduptech/aduptech.go:80:	convertCurrency	91.7%
github.com/prebid/prebid-server/v3/adapters/aduptech/aduptech.go:106:	MakeBids	100.0%
github.com/prebid/prebid-server/v3/adapters/aduptech/aduptech.go:143:	getBidType	100.0%
total:									(statements)	94.6%

github-actions bot reviewed Nov 26, 2024

View reviewed changes

danygielow mentioned this pull request Nov 26, 2024

Updated aduptech.md to add pbs: true prebid/prebid.github.io#5728

Open

8 tasks

danygielow force-pushed the feat/add-aduptech-adapter branch from 74112fe to 8e94b4b Compare November 27, 2024 06:32

github-actions bot reviewed Nov 27, 2024

View reviewed changes

bsardo added the adapter label Jan 6, 2025

bsardo assigned bsardo and przemkaczmarek Jan 7, 2025

scr-oath approved these changes Jan 7, 2025

View reviewed changes

scr-oath mentioned this pull request Jan 8, 2025

Consider making constants for currencies #4134

Open

scr-oath suggested changes Jan 8, 2025

View reviewed changes

New Adapter: AdUp Tech

2ad858d

derfryday force-pushed the feat/add-aduptech-adapter branch from 8e94b4b to 2ad858d Compare January 8, 2025 07:54

github-actions bot reviewed Jan 8, 2025

View reviewed changes

pm-isha-bharti reviewed Jan 8, 2025

View reviewed changes

scr-oath reviewed Jan 8, 2025

View reviewed changes

scr-oath suggested changes Jan 9, 2025

View reviewed changes

scr-oath reviewed Jan 9, 2025

View reviewed changes

pm-isha-bharti reviewed Jan 10, 2025

View reviewed changes

danygielow added 2 commits January 13, 2025 13:34

feat(aduptech): added more tests, changed assert to require where sen…

48deb93

…sible, fixed sync URL

test: fixed broken-response and unsupported-mtype tests

4f3580c

test(aduptech): added currency-conversion-failure test

1dc4b16

scr-oath reviewed Jan 13, 2025

View reviewed changes

style(aduptech): small code formatting changes

ec665c1

scr-oath approved these changes Jan 21, 2025

View reviewed changes

bsardo reviewed Jan 21, 2025

View reviewed changes

danygielow added 3 commits January 22, 2025 13:33

feat(aduptech): using IsResponseStatusCodeNoContent and CheckResponse…

2a38edc

…StatusCodeForErrors to check response status codes

fix(aduptech): fixed types in ExtImpAduptech, added minlength constra…

55f2048

…int to publisher and placement param, added params tests

test(aduptech): added test for invalid bidfloor currency

8315a50

	assert.NoError(t, buildErr, "Builder returned unexpected error")
	require.NoError(t, buildErr, "Builder returned unexpected error")

	"github.com/stretchr/testify/assert"
	"github.com/stretchr/testify/assert"
	"github.com/stretchr/testify/require"

	return nil, fmt.Errorf("invalid extra info: %v", err)
	return nil, fmt.Errorf("invalid extra info: %w", err)

		bidder, buildErr := Builder(openrtb_ext.BidderAdUpTech, config.Adapter{
		Endpoint: "https://example.com/rtb/bid", ExtraAdapterInfo: "{\"target_currency\": \"EUR\"}"}, config.Server{ExternalUrl: "http://hosturl.com", GvlID: 1, DataCenter: "2"})

	return nil, fmt.Errorf("invalid extra info: TargetCurrency is empty, pls check")
	return nil, errors.New("invalid extra info: TargetCurrency is empty, pls check")

		@@ -0,0 +1,27 @@
		endpoint: "https://rtb.d.adup-tech.com/rtb/bid"

New Adapter: AdUp Tech #4076

Are you sure you want to change the base?

New Adapter: AdUp Tech #4076

Conversation

danygielow commented Nov 26, 2024 • edited Loading

github-actions bot Nov 26, 2024

Choose a reason for hiding this comment

github-actions bot Nov 26, 2024

Choose a reason for hiding this comment

github-actions bot commented Nov 26, 2024

Code coverage summary

aduptech

github-actions bot Nov 27, 2024

Choose a reason for hiding this comment

github-actions bot Nov 27, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Nov 27, 2024

Code coverage summary

aduptech

bsardo commented Jan 6, 2025

bsardo commented Jan 7, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

scr-oath Jan 8, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

scr-oath left a comment

Choose a reason for hiding this comment

github-actions bot Jan 8, 2025

Choose a reason for hiding this comment

github-actions bot Jan 8, 2025

Choose a reason for hiding this comment

github-actions bot commented Jan 8, 2025

Code coverage summary

aduptech

pm-isha-bharti Jan 8, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pm-isha-bharti Jan 8, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bsardo commented Jan 8, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

scr-oath Jan 9, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

scr-oath Jan 9, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pm-isha-bharti Jan 10, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Jan 13, 2025

Code coverage summary

aduptech

github-actions bot commented Jan 13, 2025

Code coverage summary

danygielow commented Nov 26, 2024 •

edited

Loading

scr-oath Jan 8, 2025 •

edited

Loading

pm-isha-bharti Jan 8, 2025 •

edited

Loading

pm-isha-bharti Jan 8, 2025 •

edited

Loading

scr-oath Jan 9, 2025 •

edited

Loading

scr-oath Jan 9, 2025 •

edited

Loading

pm-isha-bharti Jan 10, 2025 •

edited

Loading

scr-oath Jan 13, 2025 •

edited

Loading

danygielow commented Jan 21, 2025 •

edited

Loading

scr-oath commented Jan 21, 2025 •

edited

Loading