support variant variables in sources #66
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ytausch
commented
Jan 22, 2025
| @@ -138,7 +138,7 @@ def render(template: str | list[str], context: dict[str, str]) -> str | list[str | |||
|
|
|||
| context = recipe.get("context", {}) | |||
| # render out the context section and retrieve dictionary | |||
| context_variables = load_recipe_context(context, env) | |||
| context_variables = combination | load_recipe_context(context, env) | |||
There was a problem hiding this comment.
This means that the variant variables are passed as context to the Source object below. Is this correct?
ytausch
commented
Jan 22, 2025
| @@ -125,7 +125,7 @@ def render(template: str | list[str], context: dict[str, str]) -> str | list[str | |||
| if isinstance(template, list): | |||
| return [cast(str, render(t, context)) for t in template] | |||
| template = env.from_string(template) | |||
| return template.render(context_variables) | |||
| return template.render(context) | |||
There was a problem hiding this comment.
I think this was actually a bug?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended as more of a question than a concrete proposal.
Currently,
render_all_sourcesdoes not render variables in source URLs defined by variant variables (as opposed to variables defined in the source section). However, rattler-build supports variant variables in the source section (see, e.g., https://github.com/conda-forge/polars-feedstock/pull/303/checks?check_run_id=35876450902).Does it make sense to support variant variables here too? This would enable the autotick-bot to parse such recipes.