Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#665] [도서 검색] 최근 검색어 존재하지 않을때 UI 수정 #666

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

hanyugeon
Copy link
Member

구현 내용

로그인한 사용자의
최근 검색어가 존재하지 않을 때
"검색 기록이 없어요!" 문구가 보이도록
수정했어요!

스크린샷

변경 전

image

변경 후

image

pr 포인트

const hasKeywords = keywords && keywords?.length !== 0;

...

return (
  {hasKeywords ? (
    <최근검색어 />
  ) : (
    <p>검색 기록이 없어요!</p>
  )
)

기존의 버그는 props로 받아오는 keywords가 빈배열 []일 경우에도
boolean값이 true이기 때문에 발생한 버그였어요

hasKeyword라는 boolean 형태의 변수를 만들어 해결했어요

관련 이슈

@hanyugeon hanyugeon added 🐥 프론트 필수! 🐛 fix Something isn't working 🔥 v.1.0 New feature for releasing v.1.0 labels Jul 21, 2024
@hanyugeon hanyugeon requested a review from gxxrxn July 21, 2024 08:44
@hanyugeon hanyugeon self-assigned this Jul 21, 2024
Copy link

vercel bot commented Jul 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dadok ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 21, 2024 8:44am

Copy link

Copy link

⚡️ Lighthouse Average Scores Across Reports:

Category Score
🔴 performance 68
🟢 accessibility 91
🟢 best practices 98
🟢 seo 100
🟢 pwa 100

⚡️ Average Details Across All Reports:

Category Score
🟢 first contentful paint 0.8s
🔴 largest contentful paint 13.0s
🔴 interactive 7.7s
🟢 total blocking time 191.4ms
🟢 cumulative layout shift 0.0

Copy link
Member

@gxxrxn gxxrxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@hanyugeon hanyugeon merged commit 60eaaec into main Jul 24, 2024
4 checks passed
@hanyugeon hanyugeon deleted the fix/#665 branch August 8, 2024 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 fix Something isn't working 🐥 프론트 필수! 🔥 v.1.0 New feature for releasing v.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[도서 검색] 최근 검색어 존재하지 않을때 UI 수정
2 participants