Introduced allowZero to control if zero values should be cleared when… #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… clearOnEmpty is true This fixes the case where you want to allow empty and '0' as input field values. '0' is no longer considered empty if you raise the allowZero flag.
|
The codacy review failed, but I did change anything that causes it to. |
|
@ToreOlavKristiansen you've added the control variable If you could please fix only these 3 errors related to the lines you changed. You must no pay attention to others errors. Thank you |
|
@freitasmurillo Done :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… clearOnEmpty is true
This fixes the case where you want to allow empty and '0' as input field values. '0' is no longer considered empty if you raise the allowZero flag.