Adding missing cents zeros #85

douglasresende · 2018-03-17T00:30:01Z

Test: 1.11        // do nothing
Test: 1.1         // 1.10
Test: 1           // 1.00

tr4nquility · 2018-07-16T02:55:32Z

jquery.priceformat.js

-          if (integerVal !== "0") {
-            formatted = integerVal + centsSeparator + centsVal;
-          }
-          else {
            formatted = centsSeparator + centsVal;
          }
        }


Hi Douglas,

I've faced the same issue as you did, and tried your pull request.
It seems that this curly brace needs to be removed as well, otherwise the script will break.

tr4nquility · 2018-07-16T02:57:08Z

jquery.priceformat.js

+        var str = get();
+        var new_str = fix_cents_by_str(str);
+        var price = fix_cents_by_str(price_format(str));
+        if (new_str != price) set(price);


And this one, I think it should be if (new_str != price) set(new_str).
After applying the above changes, it works as expected.

douglasresende added 4 commits March 16, 2018 21:27

Adding missing cents zeros

eb82db6

Changing the test to verify if str include a DOT

2810632

Calling method to fix cents just when start the priceformat

a7f3d5b

Fixing bug when get() is 0 and clearOnEmpty option is true

f14bfcc

nandomoreirame requested review from flaviosilveira and cuducos July 13, 2018 17:10

nandomoreirame added improvement suggestion discussion labels Jul 13, 2018

tr4nquility reviewed Jul 16, 2018

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding missing cents zeros #85

Adding missing cents zeros #85

douglasresende commented Mar 17, 2018

tr4nquility Jul 16, 2018

tr4nquility Jul 16, 2018 •

edited

Loading

Adding missing cents zeros #85

Are you sure you want to change the base?

Adding missing cents zeros #85

Conversation

douglasresende commented Mar 17, 2018

tr4nquility Jul 16, 2018

Choose a reason for hiding this comment

tr4nquility Jul 16, 2018 • edited Loading

Choose a reason for hiding this comment

tr4nquility Jul 16, 2018 •

edited

Loading