Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: ToolTip(#17243 ) - AppendTo bug #17265

Merged

Conversation

mark7p
Copy link
Contributor

@mark7p mark7p commented Dec 31, 2024

Closes #17243

Fixed wrong parameter for removeChild.

Copy link

vercel bot commented Dec 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Updated (UTC)
primeng ⬜️ Ignored (Inspect) Visit Preview Dec 31, 2024 6:42pm
primeng-v18 ⬜️ Ignored (Inspect) Visit Preview Dec 31, 2024 6:42pm

Copy link

vercel bot commented Dec 31, 2024

@mark7p is attempting to deploy a commit to the primetek Team on Vercel.

A member of the Team first needs to authorize it.

@mark7p
Copy link
Contributor Author

mark7p commented Dec 31, 2024

@rosenthalj
Copy link
Contributor

@rosenthalj I'm using removeChild from @primeuix/utils https://github.com/primefaces/primeuix/blob/3ce3c37e679a6c1c514532b6d8e016fc9277085a/packages/utils/src/dom/methods/removeChild.ts#L3-L8

My bad. So "fixing" the remove method actually corrects issue #17243?

@mark7p
Copy link
Contributor Author

mark7p commented Dec 31, 2024

Yes, the reproducer in #17243 was in v18.

When reproduced in v19, it shows different behavior (which is this PR for).

I was about to create a PR for V18, but #17243 indicated the PrimeNg version is 19

PrimeNG version
v19

so this will close the issue for v19, I'm not looking into the v18 side yet.

I understand the confusion, I was too

@mertsincan mertsincan merged commit b93a4e1 into primefaces:master Jan 15, 2025
4 of 6 checks passed
@mertsincan
Copy link
Member

Thanks a lot for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tooltip: appendTo not working when targeting elements besides body
3 participants