Update config and disable violations

primer · Oct 8, 2024 · 05aece1 · 05aece1
1 parent 77d7272
commit 05aece1
Show file tree

Hide file tree

Showing 8 changed files with 667 additions and 1,472 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -50,7 +50,7 @@
     "@mdx-js/react": "1.6.22",
     "@playwright/test": "1.43.0",
     "@prettier/sync": "0.5.1",
-    "@primer/stylelint-config": "^13.0.1-rc.5358628",
+    "@primer/stylelint-config": "13.1.1-rc.f5f9cb2",
     "@size-limit/preset-big-lib": "11.0.2",
     "@types/jest": "29.5.12",
     "@typescript-eslint/eslint-plugin": "^7.11.0",
@@ -78,7 +78,7 @@
     "prettier": "3.0.3",
     "rimraf": "5.0.5",
     "size-limit": "11.1.5",
-    "stylelint": "^16.8.1",
+    "stylelint": "16.9.0",
     "typescript": "5.4.5"
   },
   "optionalDependencies": {

diff --git a/packages/react/src/Avatar/Avatar.module.css b/packages/react/src/Avatar/Avatar.module.css
@@ -1,5 +1,3 @@
-/* stylelint-disable csstools/value-no-unknown-custom-properties */
-
 :where(.Avatar) {
   display: inline-block;
   width: var(--avatarSize-regular);

diff --git a/packages/react/src/Banner/Banner.module.css b/packages/react/src/Banner/Banner.module.css
@@ -1,7 +1,9 @@
 .Banner {
   display: grid;
   padding: var(--base-size-8);
+  /* stylelint-disable-next-line primer/colors */
   background-color: var(--banner-bgColor);
+  /* stylelint-disable-next-line primer/colors */
   border: var(--borderWidth-thin) solid var(--banner-borderColor);
   border-radius: var(--borderRadius-medium);
   grid-template-columns: auto minmax(0, 1fr) auto;
@@ -100,7 +102,9 @@
 .BannerIcon svg {
   /* 20px is the line box height of the trailing action buttons */
   height: var(--base-size-20);
+  /* stylelint-disable-next-line primer/colors */
   color: var(--banner-icon-fgColor);
+  /* stylelint-disable-next-line primer/colors */
   fill: var(--banner-icon-fgColor);
 }
 
@@ -118,6 +122,7 @@
 }
 
 .BannerDismiss svg {
+  /* stylelint-disable-next-line primer/colors */
   color: var(--banner-icon-fgColor);
 }
 

diff --git a/packages/react/src/Button/ButtonBase.module.css b/packages/react/src/Button/ButtonBase.module.css
@@ -493,6 +493,7 @@
     color: var(--button-inactive-fgColor);
     cursor: auto;
     background-color: var(--button-inactive-bgColor);
+    /* stylelint-disable-next-line primer/colors */
     border-color: var(--button-inactive-bgColor);
 
     & .Visual,

diff --git a/packages/react/src/Checkbox/Checkbox.module.css b/packages/react/src/Checkbox/Checkbox.module.css
@@ -11,6 +11,7 @@
     height: var(--base-size-16);
     visibility: hidden;
     content: '';
+    /* stylelint-disable-next-line primer/colors */
     background-color: var(--fgColor-onEmphasis);
     transition: visibility 0s linear 230ms;
     clip-path: inset(var(--base-size-16) 0 0 0);
@@ -26,6 +27,7 @@
     background: var(--control-checked-bgColor-rest);
 
     /* using bgColor here to avoid a border change in dark high contrast */
+    /* stylelint-disable-next-line primer/colors */
     border-color: var(--control-checked-bgColor-rest);
 
     &::before {
@@ -53,6 +55,7 @@
       opacity: 1;
 
       &::before {
+        /* stylelint-disable-next-line primer/colors */
         background-color: var(--control-checked-fgColor-disabled);
       }
     }

diff --git a/packages/react/src/Label/Label.module.css b/packages/react/src/Label/Label.module.css
@@ -27,6 +27,7 @@
   }
 
   &:where([data-variant='primary']) {
+    /* stylelint-disable-next-line primer/colors */
     border-color: var(--fgColor-default);
   }
 
@@ -37,21 +38,25 @@
 
   &:where([data-variant='accent']) {
     color: var(--fgColor-accent);
+    /* stylelint-disable-next-line primer/colors */
     border-color: var(--bgColor-accent-emphasis);
   }
 
   &:where([data-variant='success']) {
     color: var(--fgColor-success);
+    /* stylelint-disable-next-line primer/colors */
     border-color: var(--bgColor-success-emphasis);
   }
 
   &:where([data-variant='attention']) {
     color: var(--fgColor-attention);
+    /* stylelint-disable-next-line primer/colors */
     border-color: var(--bgColor-attention-emphasis);
   }
 
   &:where([data-variant='severe']) {
     color: var(--fgColor-severe);
+    /* stylelint-disable-next-line primer/colors */
     border-color: var(--bgColor-severe-emphasis);
   }
 
@@ -62,11 +67,13 @@
 
   &:where([data-variant='done']) {
     color: var(--fgColor-done);
+    /* stylelint-disable-next-line primer/colors */
     border-color: var(--bgColor-done-emphasis);
   }
 
   &:where([data-variant='sponsors']) {
     color: var(--fgColor-sponsors);
+    /* stylelint-disable-next-line primer/colors */
     border-color: var(--bgColor-sponsors-emphasis);
   }
 }
diff --git a/packages/react/src/experimental/IssueLabel/IssueLabel.module.css b/packages/react/src/experimental/IssueLabel/IssueLabel.module.css
@@ -4,8 +4,10 @@
   font-size: var(--text-body-size-small);
   font-weight: var(--base-text-weight-semibold);
   line-height: var(--text-body-lineHeight-small);
+  /* stylelint-disable-next-line primer/colors */
   color: var(--label-fgColor);
   white-space: nowrap;
+  /* stylelint-disable-next-line primer/colors */
   background-color: var(--label-bgColor-rest);
   border: 0;
   border-radius: var(--borderRadius-full);
@@ -20,13 +22,17 @@
     text-decoration: none;
 
     &:hover {
+      /* stylelint-disable-next-line primer/colors */
       color: var(--label-fgColor-hover);
       cursor: pointer;
+      /* stylelint-disable-next-line primer/colors */
       background-color: var(--label-bgColor-hover);
     }
 
     &:active {
+      /* stylelint-disable-next-line primer/colors */
       color: var(--label-fgColor-active);
+      /* stylelint-disable-next-line primer/colors */
       background-color: var(--label-bgColor-active);
     }