Clean up further

primer · Nov 13, 2023 · cda5fc7 · cda5fc7
1 parent 8dbe325
commit cda5fc7
Show file tree

Hide file tree

Showing 6 changed files with 3 additions and 22 deletions.
diff --git a/.changeset/lucky-gifts-rule.md b/.changeset/lucky-gifts-rule.md
@@ -2,4 +2,4 @@
 '@primer/react': minor
 ---
 
-Added `PageLayout.PaneHeading` slot to `PageLayout` which utilizes `<Heading>` as its base.
+Adjusts position of children within `PageLayout.Pane` to live above adjustable resize form.
diff --git a/docs/content/SplitPageLayout.mdx b/docs/content/SplitPageLayout.mdx
@@ -237,13 +237,13 @@ If you need a more flexible layout component, consider using the [PageLayout](/P
 </Box>
 ```
 
-### With pane heading
+### With heading
 
 ```jsx live drafts
 <Box sx={{height: 320, overflowY: 'auto', border: '1px solid', borderColor: 'border.default'}}>
   <SplitPageLayout>
     <SplitPageLayout.Pane>
-      <SplitPageLayout.PaneHeading as="h2">Pane Heading</SplitPageLayout.PaneHeading>
+      <Heading as="h2">Pane Heading</Heading>
       <Placeholder label="Pane" height={120} />
     </SplitPageLayout.Pane>
     <SplitPageLayout.Content>

diff --git a/src/PageLayout/PageLayout.tsx b/src/PageLayout/PageLayout.tsx
@@ -517,8 +517,6 @@ export type PageLayoutPaneProps = {
   resizable?: boolean
   widthStorageKey?: string
   padding?: keyof typeof SPACING_MAP
-  heading?: string
-  headingLevel?: 'h1' | 'h2' | 'h3' | 'h4' | 'h5' | 'h6'
   divider?: 'none' | 'line' | ResponsiveValue<'none' | 'line', 'none' | 'line' | 'filled'>
   /**
    * @deprecated Use the `divider` prop with a responsive value instead.

diff --git a/src/SplitPageLayout/SplitPageLayout.docs.json b/src/SplitPageLayout/SplitPageLayout.docs.json
@@ -154,21 +154,6 @@
           "type": "SystemStyleObject"
         }
       ]
-    },
-    {
-      "name": "SplitPageLayout.PaneHeading",
-      "props": [
-        {
-          "name": "as",
-          "type": "'h1' | 'h2' | 'h3' | 'h4' | 'h5' | 'h6'",
-          "required": true,
-          "defaultValue": ""
-        },
-        {
-          "name": "sx",
-          "type": "SystemStyleObject"
-        }
-      ]
     }
   ]
 }
diff --git a/src/SplitPageLayout/SplitPageLayout.stories.tsx b/src/SplitPageLayout/SplitPageLayout.stories.tsx
@@ -340,7 +340,6 @@ const Template: Story = args => (
     </SplitPageLayout.Content>
     {args['Render pane?'] ? (
       <SplitPageLayout.Pane
-        heading={args['Pane.heading']}
         resizable={args['Pane.resizable']}
         position={{
           narrow: args['Pane.position.narrow'],

diff --git a/src/SplitPageLayout/SplitPageLayout.tsx b/src/SplitPageLayout/SplitPageLayout.tsx
@@ -6,7 +6,6 @@ import {
   PageLayoutFooterProps,
   PageLayoutHeaderProps,
   PageLayoutPaneProps,
-  PageLayoutPaneHeadingProps,
 } from '../PageLayout'
 
 // ----------------------------------------------------------------------------