Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(Banner): update status for Banner so storybook urls are generated correctly #4737

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

joshblack
Copy link
Member

When testing: primer/design#818 it seems like the storybook URL that is generated for Banner is incorrect. This PR updates the status of the component so that the URLs are generated correctly

Changelog

New

Changed

  • Update Banner.docs.json to set status to draft

Removed

Rollout strategy

  • None; if selected, include a brief description as to why

This should be able to roll into a release as it's related to the metadata for PRC

Testing & Reviewing

  • Run npm run build:components.json in packages/react
  • Verify that the URLs for Banner are correct

@joshblack joshblack requested a review from a team as a code owner July 12, 2024 14:28
@joshblack joshblack requested a review from langermank July 12, 2024 14:28
Copy link

changeset-bot bot commented Jul 12, 2024

⚠️ No Changeset found

Latest commit: be2279d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Jul 12, 2024
@joshblack joshblack added skip changeset This change does not need a changelog and removed staff Author is a staff member labels Jul 12, 2024
Copy link
Contributor

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 91.18 KB (0%)
packages/react/dist/browser.umd.js 91.53 KB (0%)

@joshblack joshblack added this pull request to the merge queue Jul 12, 2024
Merged via the queue into main with commit ba253d7 Jul 12, 2024
37 of 38 checks passed
@joshblack joshblack deleted the docs/update-banner-storybook-urls branch July 12, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants