Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storybook] Move FilteredSearch FilterList to deprecated folder #4749

Merged
merged 2 commits into from
Jul 18, 2024

Conversation

tbenning
Copy link
Contributor

Closes #

Changed

Moved FilteredSearch and FilterList to deprecated folder in Storybook. This is to match Primer.style, where it already lives in the deprecated section. There's more to be done to full deprecate this, but this is cleanup work to get started on the journey.

Rollout strategy

I'm not actually sure, this is just a change in storybook docs.

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

N/A

Merge checklist

@tbenning tbenning requested a review from a team as a code owner July 18, 2024 16:57
@tbenning tbenning requested a review from camertron July 18, 2024 16:57
Copy link

changeset-bot bot commented Jul 18, 2024

⚠️ No Changeset found

Latest commit: 8ef1eef

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Jul 18, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 91.21 KB (0%)
packages/react/dist/browser.umd.js 91.54 KB (0%)

@github-actions github-actions bot temporarily deployed to storybook-preview-4749 July 18, 2024 17:01 Inactive
@joshblack joshblack added the skip changeset This change does not need a changelog label Jul 18, 2024
@tbenning tbenning added the skip changeset This change does not need a changelog label Jul 18, 2024
@joshblack joshblack enabled auto-merge July 18, 2024 17:06
@joshblack
Copy link
Member

@tbenning just pushed up a commit for VRT to update the paths for these stories, hope that's okay!

@joshblack joshblack added this pull request to the merge queue Jul 18, 2024
Merged via the queue into main with commit 0f86c7a Jul 18, 2024
30 checks passed
@joshblack joshblack deleted the tbenning/deprecate-filterlist-filteredsearch branch July 18, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants