Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storybook] Update Storybook to move DialogV1 to deprecated #4758

Closed
wants to merge 2 commits into from
Closed

[Storybook] Update Storybook to move DialogV1 to deprecated #4758

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2119fb7
Update path for dialogV1
tbenning Jul 19, 2024
40b6002
update e2e for vrt
tbenning Jul 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions e2e/components/Dialogv1.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ test.describe('Dialog v1', () => {
test.describe(theme, () => {
test('default @vrt', async ({page}) => {
await visit(page, {
id: 'components-dialogv1--default',
id: 'deprecated-components-dialogv1--default',
globals: {
colorScheme: theme,
},
Expand All @@ -21,7 +21,7 @@ test.describe('Dialog v1', () => {

test('axe @aat', async ({page}) => {
await visit(page, {
id: 'components-dialogv1--default',
id: 'deprecated-components-dialogv1--default',
globals: {
colorScheme: theme,
},
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/Dialog.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import {default as Dialog} from './Dialog'
/* Dialog Version 1*/

export default {
title: 'Components/DialogV1',
title: 'Deprecated/Components/DialogV1',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're comfortable doing this for Dialog, I think it would be good to do the same for Tooltip. This was mentioned during today's Primer Patterns working session.

Copy link
Contributor Author

@tbenning tbenning Jul 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup! I had drafted a PR for this and just flipped it to review

component: Dialog,
} as Meta

Expand Down
Loading