Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storybook: Add alt text to Avatar examples #4767

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Storybook: Add alt text to Avatar examples #4767

merged 1 commit into from
Jul 24, 2024

Conversation

siddharthkp
Copy link
Member

@siddharthkp siddharthkp commented Jul 23, 2024 •
edited
Loading 

- <Avatar square src="https://avatars.githubusercontent.com/primer" />
+ <Avatar square alt="primer" src="https://avatars.githubusercontent.com/primer" />

@changeset-bot changeset-bot

This comment was marked as resolved.

Sign in to view
@siddharthkp siddharthkp requested a review from TylerJDev July 23, 2024 14:13
@siddharthkp siddharthkp added the skip changeset This change does not need a changelog label Jul 23, 2024
@github-actions github-actions bot added the staff Author is a staff member label Jul 23, 2024
@siddharthkp siddharthkp self-assigned this Jul 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 92.37 KB (0%)
packages/react/dist/browser.umd.js 92.69 KB (0%)

@siddharthkp siddharthkp marked this pull request as ready for review July 23, 2024 14:18
@siddharthkp siddharthkp requested a review from a team as a code owner July 23, 2024 14:18
@siddharthkp siddharthkp added this pull request to the merge queue Jul 24, 2024
Merged via the queue into main with commit bd362cb Jul 24, 2024
37 of 38 checks passed
@siddharthkp siddharthkp deleted the storybook-avatar-alt-text branch July 24, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerJDev TylerJDev TylerJDev approved these changes

Assignees

@siddharthkp siddharthkp

Labels
skip changeset This change does not need a changelog staff Author is a staff member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@siddharthkp @TylerJDev