Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Label font weight to match Rails component #4865

Merged
merged 4 commits into from
Aug 23, 2024

Conversation

camertron
Copy link
Contributor

Closes https://github.com/github/primer/issues/3871

Before After
A screenshot of the existing Label component with a font weight of 600 A screenshot of the modified Label component with a font weight of 500

Changelog

No API changes.

New

Changed

The font weight of Label components has been changed from bold to semibold to match the Rails component.

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

None, this change is visual-only.

Merge checklist

- [ ] Added/updated tests
- [ ] Added/updated documentation
- [ ] Added/updated previews (Storybook)
- [ ] Changes are SSR compatible
- [ ] Tested in Chrome
- [ ] Tested in Firefox
- [ ] Tested in Safari
- [ ] Tested in Edge
- [ ] (GitHub staff only) Integration tests pass at github/github (Learn more about how to run integration tests)

Copy link

changeset-bot bot commented Aug 20, 2024

🦋 Changeset detected

Latest commit: c011dd2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@camertron camertron changed the title Update Label font weight to match Rails component Update Label font weight to match Rails component Aug 20, 2024
Copy link
Contributor

github-actions bot commented Aug 20, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 96.29 KB (+0.1% 🔺)
packages/react/dist/browser.umd.js 96.57 KB (+0.03% 🔺)

@github-actions github-actions bot temporarily deployed to storybook-preview-4865 August 20, 2024 21:28 Inactive
@primer primer bot temporarily deployed to github-pages August 21, 2024 16:52 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-4865 August 21, 2024 16:52 Inactive
@camertron camertron marked this pull request as ready for review August 21, 2024 17:01
@camertron camertron requested review from a team as code owners August 21, 2024 17:01
@camertron camertron enabled auto-merge August 22, 2024 18:47
@camertron camertron disabled auto-merge August 22, 2024 18:47
@camertron camertron enabled auto-merge August 22, 2024 20:14
@camertron camertron added this pull request to the merge queue Aug 23, 2024
Merged via the queue into main with commit ce2c674 Aug 23, 2024
30 checks passed
@camertron camertron deleted the update_label_font_weight branch August 23, 2024 18:18
@primer primer bot mentioned this pull request Aug 23, 2024
@primer primer bot mentioned this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants