Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Button VRT snapshots #4919

Merged
merged 3 commits into from
Sep 5, 2024
Merged

Update Button VRT snapshots #4919

merged 3 commits into from
Sep 5, 2024

Conversation

langermank
Copy link
Contributor

@langermank langermank commented Sep 5, 2024 •
edited
Loading

It seems like button snapshots didn't fully update when I bumped primer/primitives recently, so resetting them here as to not conflict with the button-css-modules branch.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 5, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 6f09349

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 5, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 96.41 KB (0%)
packages/react/dist/browser.umd.js 96.65 KB (0%)

@github-actions github-actions bot temporarily deployed to storybook-preview-4919 September 5, 2024 14:40 Inactive
@langermank langermank added the skip changeset This change does not need a changelog label Sep 5, 2024
@langermank langermank changed the title Testing button snaps Update Button VRT snapshots Sep 5, 2024
@langermank langermank marked this pull request as ready for review September 5, 2024 15:09
@langermank langermank requested review from a team as code owners September 5, 2024 15:09
@langermank langermank added this pull request to the merge queue Sep 5, 2024
Merged via the queue into main with commit 230ac87 Sep 5, 2024
34 of 35 checks passed
@langermank langermank deleted the test-update-button-snaps branch September 5, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshblack joshblack joshblack approved these changes

@maximedegreve maximedegreve Awaiting requested review from maximedegreve maximedegreve is a code owner automatically assigned from primer/design-reviewers

@jonrohan jonrohan Awaiting requested review from jonrohan jonrohan is a code owner automatically assigned from primer/engineer-reviewers

Assignees
No one assigned
Labels
skip changeset This change does not need a changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@langermank @joshblack