Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: IconButton dev stories - make target size 24x24 px #4924

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

francinelucca
Copy link
Member

@francinelucca francinelucca commented Sep 5, 2024

Closes https://github.com/github/primer/issues/3424

Changelog

Changed

  • Update Dev-Only "Custom Size" and "Custom Size With Media" Storybook stories' button size to 24x24 for a11y compliance

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Storybook only change, not relevant to deployed package.

Testing & Reviewing

Merge checklist

Copy link

changeset-bot bot commented Sep 5, 2024

⚠️ No Changeset found

Latest commit: b910da6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 5, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 96.54 KB (0%)
packages/react/dist/browser.umd.js 96.82 KB (0%)

Copy link
Member

@siddharthkp siddharthkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love to see it!

Approved, merge whenever you'd like

@francinelucca francinelucca added this pull request to the merge queue Sep 9, 2024
Merged via the queue into main with commit 1734756 Sep 9, 2024
39 of 44 checks passed
@francinelucca francinelucca deleted the francinelucca/icon-button-a11y-size branch September 9, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants