Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cssnano to postcss-primer-preset package and move custom properties fallback #4926

Merged
merged 7 commits into from
Sep 5, 2024

Conversation

jonrohan
Copy link
Member

@jonrohan jonrohan commented Sep 5, 2024

This updates the postcss-primer-preset package to use cssnano to minify the CSS output.

  • Include cssnano in the postcss-primer-preset package.
  • Move the custom properties fallback out of the react package rollup config and into the preset

This shouldn't have any effect on components other than a minified output for the CSS.

@jonrohan jonrohan requested a review from a team as a code owner September 5, 2024 21:12
@jonrohan jonrohan requested a review from camertron September 5, 2024 21:12
Copy link

changeset-bot bot commented Sep 5, 2024

⚠️ No Changeset found

Latest commit: bf9281b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Sep 5, 2024
@jonrohan jonrohan requested review from joshblack and removed request for camertron September 5, 2024 21:13
Copy link
Contributor

github-actions bot commented Sep 5, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 96.54 KB (0%)
packages/react/dist/browser.umd.js 96.82 KB (0%)

@jonrohan jonrohan added the skip changeset This change does not need a changelog label Sep 5, 2024
@jonrohan jonrohan enabled auto-merge September 5, 2024 21:50
@github-actions github-actions bot temporarily deployed to storybook-preview-4926 September 5, 2024 21:54 Inactive
@jonrohan jonrohan added this pull request to the merge queue Sep 5, 2024
Merged via the queue into main with commit a33d6c2 Sep 5, 2024
30 checks passed
@jonrohan jonrohan deleted the postcss-preset-updates branch September 5, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants