fix(PageHeader): include role and aria-label in top-level element #4949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 851e72f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
francinelucca
added
staff
francinelucca
temporarily deployed
to
github-pages
GitHub Actions
Inactive
size-limit report 📦
|
francinelucca
temporarily deployed
to
github-pages
GitHub Actions
Inactive
|
👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/341657 |
|
This change will introduce a11y violations, going with another strategy, closing |
francinelucca
deleted the
francinelucca/3466-prcpageheader-best-practice-container-lacks-a-role
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #https://github.com/github/primer/issues/3466
Changelog
New
PageHeadertests to assert added functionalityChanged
PageHeader'saria-labeldocs description to reference "banner landmark" instead of "main landmark"aria-labelprop inPageHeaderPlayground storyaria-labelattribute inPageHeader's "root" element mapped to the suppliedaria-label(defaults to "banner")Removed
N/A
Rollout strategy
Testing & Reviewing
Boxelement and thearia-labelthat maps to thetitleproptitleprop in playground and notice thearia-labelchange in the DOM as wellBoxelement and thearia-labelthat defaults to "banner"Merge checklist