Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add support for css to storybook #4950

Merged
merged 15 commits into from
Sep 12, 2024
Merged

docs: add support for css to storybook #4950

merged 15 commits into from
Sep 12, 2024

Conversation

joshblack
Copy link
Member

@joshblack joshblack commented Sep 11, 2024 •
edited
Loading

It seems like our existing CSS in place in Storybook is not working as intended and only style-loader is getting applied 😓 This PR updates the Storybook configuration to work correctly with CSS Modules and correctly apply our postcss config to it.

Changelog

New

Changed

  • Update storybook config to process CSS Modules

Removed

  • Removed deprecated @storybook/addon-styling package

Rollout strategy

  • None; if selected, include a brief description as to why

This is a change to our storybook setup

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 11, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: c14d238

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Sep 11, 2024
@joshblack joshblack added the skip changeset This change does not need a changelog label Sep 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 11, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 96.93 KB (-0.31% 🔽)
packages/react/dist/browser.umd.js 97.25 KB (-0.38% 🔽)

@github-actions github-actions bot temporarily deployed to storybook-preview-4950 September 11, 2024 19:12 Inactive
@joshblack joshblack marked this pull request as ready for review September 11, 2024 19:14
@joshblack joshblack requested a review from a team as a code owner September 11, 2024 19:14
@github-actions github-actions bot temporarily deployed to storybook-preview-4950 September 11, 2024 19:18 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-4950 September 11, 2024 19:41 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-4950 September 12, 2024 17:57 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-4950 September 12, 2024 18:02 Inactive
@joshblack joshblack requested a review from jonrohan September 12, 2024 18:14
jonrohan
jonrohan approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@jonrohan jonrohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beautiful

@joshblack joshblack added this pull request to the merge queue Sep 12, 2024
Merged via the queue into main with commit aaeecdb Sep 12, 2024
30 checks passed
@joshblack joshblack deleted the docs/update-storybook-css branch September 12, 2024 18:42
TylerJDev pushed a commit that referenced this pull request Sep 23, 2024
@joshblack @TylerJDev
docs: add support for css to storybook (#4950)
b0061ed 
* docs: add support for css to storybook

* chore: remove commented code

* chore: add explicit dependency used by storybook tool

* chore: add dependency used by internal addon

* refactor: update internal storybook dependencies

* chore(deps): update deps version

* chore: run npm dedupe

* chore: update stories

* chore: try out different loader techniques

* refactor(storybook): update from @storybook/react-webpack5 to @storybook/react-vite

* chore: update settings to match rollup build output

* chore: remove top-level postcss config

---------

Co-authored-by: Josh Black <joshblack@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@langermank langermank langermank approved these changes

@jonrohan jonrohan jonrohan approved these changes

Assignees
No one assigned
Labels
skip changeset This change does not need a changelog staff Author is a staff member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshblack @jonrohan @langermank