Allow color to be customized for medium-sized IconButtons
#4989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8864f9f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
camertron
temporarily deployed
to
github-pages
GitHub Actions
Inactive
size-limit report 📦
|
camertron
temporarily deployed
to
github-pages
GitHub Actions
Inactive
camertron
force-pushed
the
icon_button_color_fix
branch
from
04d7172 to
4a4d11c
Compare
camertron
temporarily deployed
to
github-pages
GitHub Actions
Inactive
joshblack
approved these changes
Sep 19, 2024
TylerJDev
pushed a commit
that referenced
this pull request
Sep 23, 2024
* Allow color to be specified for medium-sized IconButtons * Add changeset * Build * Fix Button component * Update snapshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Customizing the color of small and large
IconButtons works as expected because the component generates a stylesheet with rules targeting the size, eg.[data-size='small'] { color: green }. However for the default, medium, no size attribute is attached to the button and the generated stylesheet does not use it in its rules. This leads to a CSS specificity problem where the default color has a higher specificity than the custom color, meaning the custom color is not applied as expected.This PR removes the special handling of the medium size, which results in the
data-sizeattribute being added to the button and a generated stylesheet that targets it.Closes #4863
Changelog
New
Changed
IconButtonsRemoved
Rollout strategy