Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS Modules authoring guide #5037

Merged
merged 18 commits into from
Oct 17, 2024
Merged

CSS Modules authoring guide #5037

merged 18 commits into from
Oct 17, 2024

Conversation

jonrohan
Copy link
Member

@jonrohan jonrohan commented Sep 26, 2024 •
edited
Loading

Closes https://github.com/github/primer/issues/3655

Changelog

New

Changed

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 26, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 6dc7406

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Sep 26, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5037 September 26, 2024 17:25 Inactive
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 26, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 97.06 KB (0%)
packages/react/dist/browser.umd.js 97.36 KB (0%)

@github-actions github-actions bot temporarily deployed to storybook-preview-5037 October 7, 2024 16:58 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5037 October 9, 2024 16:20 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5037 October 9, 2024 18:08 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5037 October 17, 2024 16:55 Inactive
@langermank langermank changed the title CSS authoring guide CSS Modules authoring guide Oct 17, 2024
@langermank langermank marked this pull request as ready for review October 17, 2024 16:56
@langermank langermank requested a review from a team as a code owner October 17, 2024 16:56
@langermank langermank self-requested a review October 17, 2024 16:56
@github-actions github-actions bot temporarily deployed to storybook-preview-5037 October 17, 2024 16:58 Inactive
joshblack
joshblack approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

contributor-docs/authoring-css.md Outdated Show resolved Hide resolved
contributor-docs/authoring-css.md Outdated Show resolved Hide resolved
contributor-docs/authoring-css.md Outdated Show resolved Hide resolved
contributor-docs/authoring-css.md Outdated
```tsx
// don't offer multiple classNames
export function Button({className, labelClassName}) {
return
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the return needs to be wrapped in parenthesis for the formatting to kick in 👀

langermank and others added 2 commits October 17, 2024 11:58
@langermank @joshblack
Apply suggestions from code review
eaf9744 
Co-authored-by: Josh Black <joshblack@github.com>
@langermank
format
ef09b6b
@github-actions github-actions bot temporarily deployed to storybook-preview-5037 October 17, 2024 19:01 Inactive
jonrohan
jonrohan commented Oct 17, 2024
View reviewed changes
Copy link
Member Author

@jonrohan jonrohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it 👍🏻

@langermank langermank added the skip changeset This change does not need a changelog label Oct 17, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5037 October 17, 2024 20:00 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5037 October 17, 2024 20:21 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5037 October 17, 2024 20:27 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5037 October 17, 2024 21:25 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5037 October 17, 2024 21:42 Inactive
@langermank langermank added this pull request to the merge queue Oct 17, 2024
Merged via the queue into main with commit 4680ce6 Oct 17, 2024
44 checks passed
@langermank langermank deleted the css-docs branch October 17, 2024 22:02
@keithamus keithamus mentioned this pull request Oct 18, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshblack joshblack joshblack approved these changes

@langermank langermank Awaiting requested review from langermank langermank is a code owner automatically assigned from primer/engineer-reviewers

Assignees
No one assigned
Labels
skip changeset This change does not need a changelog staff Author is a staff member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonrohan @joshblack @langermank