Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update popover-polyfill #5069

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Update popover-polyfill #5069

merged 1 commit into from
Oct 4, 2024

Conversation

dgreif
Copy link
Member

@dgreif dgreif commented Oct 4, 2024

I was updating @oddbird/popover-polyfill to 0.4.4 from 0.4.3 in dotcom and realized PRC is still requesting a much older version. PRC was requesting ^0.3.1, which does not match 0.4.3 since the major version is 0. I'd like to get PRC updated to the same version (or at least version range) we use in dotcom.

Changelog

New

Changed

  • Updated @oddbird/popover-polyfill to 0.4.4

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

I don't know that I have a good browser version to test popover polyfill in! Looks like all the modern browsers are well covered with native functionality. We are already using 0.4.3 in dotcom, so I don't expect any issues.

Merge checklist

@dgreif dgreif requested a review from a team as a code owner October 4, 2024 18:21
@dgreif dgreif requested a review from TylerJDev October 4, 2024 18:21
Copy link

changeset-bot bot commented Oct 4, 2024

⚠️ No Changeset found

Latest commit: 4b21570

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 4, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 96.77 KB (+0.05% 🔺)
packages/react/dist/browser.umd.js 97.15 KB (+0.16% 🔺)

@lesliecdubs lesliecdubs requested review from broccolinisoup and removed request for TylerJDev October 4, 2024 19:50
@jonrohan jonrohan added this pull request to the merge queue Oct 4, 2024
Merged via the queue into main with commit 2651510 Oct 4, 2024
38 of 39 checks passed
@jonrohan jonrohan deleted the dg/update-popover-polyfill branch October 4, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants