Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IconButton: Add tooltipDirection prop to prop docs #5084

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

broccolinisoup
Copy link
Member

@broccolinisoup broccolinisoup commented Oct 7, 2024

Came up internally that we don't have tooltipDirection prop for IconButton documented on the docs.

Changelog

New

  • Add tooltipDirection prop to the docs.json

Changed

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • [ xNone; if selected, include a brief description as to why

Testing & Reviewing

Copy link

changeset-bot bot commented Oct 7, 2024

⚠️ No Changeset found

Latest commit: 9cf7468

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 7, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 96.7 KB (0%)
packages/react/dist/browser.umd.js 97.02 KB (0%)

@broccolinisoup broccolinisoup added the skip changeset This change does not need a changelog label Oct 7, 2024
@broccolinisoup broccolinisoup marked this pull request as ready for review October 7, 2024 23:12
@broccolinisoup broccolinisoup requested a review from a team as a code owner October 7, 2024 23:12
@broccolinisoup broccolinisoup added this pull request to the merge queue Oct 7, 2024
Merged via the queue into main with commit ce14f85 Oct 8, 2024
49 of 50 checks passed
@broccolinisoup broccolinisoup deleted the icon-button-tooltip-direction branch October 8, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants