Docs(SplitPageLayout): add PageLayout props to .docs.json #5108
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/github/primer/issues/3575
The SplitPageLayout.Pane component is a PageLayout.Pane under the hood and can therefore accept any props that PageLayout.Pane accepts. This PR updates the documentation to reflect some missing props, including
aria-label
,aria-labelledby
.This PR also adds
aria-label
toPane
s inSplitPageLayout
stories so that it can be displayed when the content overflows.Changelog
New
aria-label
,aria-labelledby
props toSplitPageLayout.Pane
docs.json filewidth
prop inSplitPageLayout.Pane
docs.json file to more closely match withPageLayout.Pane
docsaria-label
prop toPane
s inSplitPageLayout
storiesRollout strategy
Docs only update
Testing & Reviewing
Navigate to deployed
SplitPageLayout.Pane
story and resize browser so that the pane overflows, verify in the DOM thataria-label
prop is added, along with tabIndex=0 and role='region'Merge checklist