Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(project): update lint-staged #5112

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Conversation

joshblack
Copy link
Member

Noticed now that husky is running on the project and that it was using the npm run lint task which can take a while when committing 😅

This PR updates it to use what are (hopefully) different commands that only check on the files being committed and autofixes them.

Changelog

New

Changed

  • Update lint-staged config in package.json to include checks for ts/css files that use prettier and eslint/stylelint

Removed

Rollout strategy

  • None; if selected, include a brief description as to why

@joshblack joshblack requested a review from a team as a code owner October 11, 2024 15:48
@joshblack joshblack requested a review from jonrohan October 11, 2024 15:48
Copy link

changeset-bot bot commented Oct 11, 2024

⚠️ No Changeset found

Latest commit: 62dc606

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@joshblack joshblack assigned joshblack and unassigned joshblack Oct 11, 2024
@joshblack joshblack added the skip changeset This change does not need a changelog label Oct 11, 2024
@github-actions github-actions bot added the staff Author is a staff member label Oct 11, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5112 October 11, 2024 15:50 Inactive
Copy link
Contributor

github-actions bot commented Oct 11, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 97.61 KB (0%)
packages/react/dist/browser.umd.js 97.79 KB (0%)

Copy link
Member

@broccolinisoup broccolinisoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh this is probably why we see https://github.com/primer/react/actions/runs/11318033884/job/31474312035!

Thanks 🔥 I'm merging this asap ✈️

@broccolinisoup broccolinisoup added this pull request to the merge queue Oct 14, 2024
Merged via the queue into main with commit fe26bc3 Oct 14, 2024
43 checks passed
@broccolinisoup broccolinisoup deleted the chore/update-lint-staged branch October 14, 2024 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants